Skip to content

mesa3d: fix default of MESA3D_PLATFORM #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhubert wants to merge 1 commit into from
Closed

mesa3d: fix default of MESA3D_PLATFORM #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recipes/libs/mesa3d.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ multiPackage:
- graphics::wayland::wayland-protocols
- graphics::wayland::wayland-dev

- if: "$(eq,$MESA3D_PLATFORM,x11)"
- if: "$(eq,$MESA3D_PLATFORM,wayland)"
Copy link
Member

@jkloetzke jkloetzke Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Now, if $MESA3D_PLATFORM equals wayland, we add the X11 dependencies. Which contradicts the commit message. What am I missing?

Copy link
Contributor Author

@rhubert rhubert Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 our recipes are based on an older version of the basement where we can not use the default attribute in the Config section. That's why we had if: "$(eq,${MESA3D_PLATFORM:-x11},x11) here. ATM I'm upstreaming my changes in order to rebase later and obviously I wasn't very focused yesterday... Sorry for the noise..

Copy link
Member

@jkloetzke jkloetzke Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries!

depends:
- graphics::xorg::proto::xorgproto
- libs::xcb::libxcb-dev
Expand Down Expand Up @@ -148,7 +148,7 @@ multiPackage:
- if: "$(eq,$MESA3D_PLATFORM,wayland)"
name: graphics::wayland::wayland-tgt

- if: "$(eq,$MESA3D_PLATFORM,x11)"
- if: "$(eq,$MESA3D_PLATFORM,wayland)"
depends:
- libs::xcb::libxcb-tgt
- libs::xorg::libX11-tgt
Expand Down