mesa3d: fix default of MESA3D_PLATFORM #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not depend on X dependencies if the default (wayland) is used.
jkloetzke
reviewed
Aug 6, 2025
| - graphics::wayland::wayland-dev | ||
|
|
||
| - if: "$(eq,$MESA3D_PLATFORM,x11)" | ||
| - if: "$(eq,$MESA3D_PLATFORM,wayland)" |
Member
There was a problem hiding this comment.
I'm confused. Now, if $MESA3D_PLATFORM equals wayland, we add the X11 dependencies. Which contradicts the commit message. What am I missing?
Contributor
Author
There was a problem hiding this comment.
🤦 our recipes are based on an older version of the basement where we can not use the default attribute in the Config section. That's why we had if: "$(eq,${MESA3D_PLATFORM:-x11},x11) here. ATM I'm upstreaming my changes in order to rebase later and obviously I wasn't very focused yesterday... Sorry for the noise..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not depend on X dependencies if the default (wayland) is used.