Skip to content

Bump simplicity version#364

Merged
apoelstra merged 1 commit into
BlockstreamResearch:masterfrom
ivanlele:chore/bump-0.7.1
May 17, 2026
Merged

Bump simplicity version#364
apoelstra merged 1 commit into
BlockstreamResearch:masterfrom
ivanlele:chore/bump-0.7.1

Conversation

@ivanlele
Copy link
Copy Markdown
Contributor

@ivanlele ivanlele commented May 6, 2026

No description provided.

@ivanlele
Copy link
Copy Markdown
Contributor Author

ivanlele commented May 6, 2026

@apoelstra, In the changelog, I tried to keep CI/bench/dev staff out

@stringhandler
Copy link
Copy Markdown
Contributor

There are a few places that say rust_simplicity_0_6_0 in the source. Do we update these?

@apoelstra
Copy link
Copy Markdown
Collaborator

Oops, good catch.

When we did #353 we should've updated the version of simplicity-sys. If we'd updated that version, all these constants would've changed.

We should open a separate PR which bumps the version of simplicity-sys and re-runs ./vendor-simplicity.sh which should fix this.

@ivanlele
Copy link
Copy Markdown
Contributor Author

ivanlele commented May 6, 2026

We should open a separate PR which bumps the version of simplicity-sys and re-runs ./vendor-simplicity.sh which should fix this.

Created PR #365 for this

@ivanlele ivanlele marked this pull request as ready for review May 12, 2026 08:27
@ivanlele
Copy link
Copy Markdown
Contributor Author

@apoelstra, with #362 merged and #365 approved (only the merge remains), do we have everything needed to roll out the new rust-simplicity version?

About your comment in BlockstreamResearch/SimplicityHL#224, I think the thing I suggested there might make the BlockstreamResearch/SimplicityHL#314 diff even worse. Without an updated rust-simplicity version to implement it, it would require adding many new generic parameters. So I think we first need the new rust-simplicity release before we can continuing iteration after BlockstreamResearch/SimplicityHL#322, which I made yesterday

@apoelstra
Copy link
Copy Markdown
Collaborator

Sorry, I have been travelling, hence the delays in these PRs. I will try to get this in today so it's ready for work on Monday.

@ivanlele
Copy link
Copy Markdown
Contributor Author

Sorry, I have been travelling, hence the delays in these PRs. I will try to get this in today so it's ready for work on Monday.

Np! Have a good road

Copy link
Copy Markdown
Collaborator

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 00d3625; successfully ran local tests

@apoelstra
Copy link
Copy Markdown
Collaborator

Tagged and published.

@apoelstra apoelstra merged commit ad9647f into BlockstreamResearch:master May 17, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants