Add JetHL trait implementation and usage across modules#322
Open
ivanlele wants to merge 1 commit into
Open
Conversation
Contributor
|
I released the new rust-simplicity in BlockstreamResearch/rust-simplicity#364 -- do we want to adjust this PR? |
Author
I’d say yes, but first we need to update the rust-simplicity dep. @stringhandler, we have everything we need to finish #314 now. |
ivanlele
force-pushed
the
refactor/jethl-trait
branch
2 times, most recently
from
53cda1e to
7e3ecfa
Compare
ivanlele
force-pushed
the
refactor/jethl-trait
branch
from
7e3ecfa to
fdf2bb1
Compare
Author
|
@KyrylR @apoelstra this one can be reviewed again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR advances progress on issue #224. It introduces a new
JetHLtrait, which encapsulates all logic required forsimcto function in addition to the default Jet methods. The follow-up would include insertingJetHLbetween interface invocations and the topmostsimcentrypoint.