Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Description

Adds XML comments to POM files explaining why spring-boot-starter-jackson is excluded and replaced with spring-boot-jackson2:

  • xapi-client/pom.xml - comment on webflux starter exclusion
  • xapi-model-spring-boot-starter/pom.xml - comment on web starter exclusion

The comments note that jjwt does not currently support Jackson 3 and the exclusion should be removed once jjwt adds support.

Resolves review feedback from #409

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Copilot AI changed the title [WIP] Add comment to POM regarding jjwt exclusion and Jackson 3 support Add comment to POM regarding jjwt exclusion and Jackson 3 support Nov 25, 2025
Copilot AI requested a review from thomasturrell November 25, 2025 03:26
@thomasturrell thomasturrell marked this pull request as ready for review November 25, 2025 03:32
@thomasturrell thomasturrell merged commit 97e3ac2 into dependabot/maven/org.springframework.boot-spring-boot-starter-parent-4.0.0 Nov 25, 2025
@thomasturrell thomasturrell deleted the copilot/sub-pr-409-again branch November 25, 2025 03:33
thomasturrell added a commit that referenced this pull request Nov 25, 2025
…o 4.0.0 (#409)

* Bump org.springframework.boot:spring-boot-starter-parent

Bumps [org.springframework.boot:spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 3.5.7 to 4.0.0.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.5.7...v4.0.0)

---
updated-dependencies:
- dependency-name: org.springframework.boot:spring-boot-starter-parent
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix Spring Boot 4.0.0 compatibility - add Jackson 2 support module (#418)

* Add comment to POM regarding jjwt exclusion and Jackson 3 support (#424)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Turrell-Croft <thomasturrell@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants