Skip to content

chore(ci): update maven workflows to use maven wrapper and add javadoc validation #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasturrell merged 5 commits into from
Nov 18, 2025
Merged

chore(ci): update maven workflows to use maven wrapper and add javadoc validation #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4066f99
Initial plan
Copilot Nov 18, 2025
9164094
chore(ci): consolidate maven workflows into .github/workflows/maven-c…
Copilot Nov 18, 2025
8bc10a2
chore(ci): restore maven_push.yml as requested
Copilot Nov 18, 2025
95c84c3
chore(ci): restore maven_pull_request.yml, delete maven-ci.yml, and u…
Copilot Nov 18, 2025
66524a2
fix(ci): change maven_pull_request.yml to use install instead of veri…
Copilot Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions .github/workflows/maven-publish-snapshot.yml
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions .github/workflows/maven-publish.yml
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions .github/workflows/maven_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,14 @@ jobs:
distribution: "temurin"
cache: maven
- name: Build with Maven
run: mvn -B verify --file pom.xml
run: ./mvnw -B install
- name: Check documentation
run: ./mvnw -B javadoc:javadoc -pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am # This checks that the Javadoc is valid
- name: Scan with Sonar
run: |
if [ $FORK = false ] && [ "$ACTOR" != "dependabot[bot]" ]
then
mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud --file pom.xml
./mvnw org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud
fi
env:
FORK: ${{ github.event.pull_request.head.repo.fork }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/maven_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
distribution: "temurin"
cache: maven
- name: Build with Maven
run: mvn -B verify --file pom.xml
run: ./mvnw -B verify
- name: Scan with Sonar
run: mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud --file pom.xml
run: ./mvnw org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down