-
Notifications
You must be signed in to change notification settings - Fork 4
chore(ci): update maven workflows to use maven wrapper and add javadoc validation #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…i.yml and remove duplicates Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
thomasturrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot make sure all workflows that we keep use the maven wrapper. check all usage of --file parameter and remove if unnecessary
…pdate workflows to use maven wrapper Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the Maven CI workflows by adopting the Maven wrapper and enhancing documentation validation. The changes simplify the workflow configuration while adding quality checks.
- Updates existing workflows to use Maven wrapper (
./mvnw) for consistent builds - Adds Javadoc validation to the pull request workflow for production modules
- Removes two deprecated/redundant workflow files that are no longer needed
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/maven_push.yml |
Updated to use Maven wrapper and removed unnecessary --file pom.xml parameters |
.github/workflows/maven_pull_request.yml |
Updated to use Maven wrapper, added Javadoc validation step for production modules, removed unnecessary parameters |
.github/workflows/maven-publish.yml |
Removed deprecated manual release workflow (replaced by automated release.yml) |
.github/workflows/maven-publish-snapshot.yml |
Removed redundant snapshot publishing workflow (functionality handled by release.yml) |
…fy to ensure artifacts are available for javadoc Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>
|



Description
Updates existing Maven workflows to use the Maven wrapper and adds Javadoc validation to the pull request workflow. Removes two redundant Maven workflows while keeping the primary CI workflows.
Changes
Kept and Updated
.github/workflows/maven_push.yml:./mvnw) instead ofmvn--file pom.xmlparametersKept and Updated
.github/workflows/maven_pull_request.yml:./mvnw) instead ofmvnverifytoinstallto ensure artifacts are available in the local Maven repository for javadoc validation--file pom.xmlparametersRemoved redundant workflows:
maven-publish.yml(deprecated manual workflow)maven-publish-snapshot.yml(functionality handled by release.yml)Notes
release.ymlhandles automated releases via GitHub release creation (unchanged)codeql.ymlandstale.ymlremain unchanged./mvnw) for consistencyxapi-model,xapi-client, andxapi-model-spring-boot-startermodulesinstallphase instead ofverifyto ensure artifacts are installed in the local repository, making them available for the javadoc validation step that uses-am(also-make) flagChecklist:
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.