Skip to content

Closes #5187: fPIC option for arrow make #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajpotts merged 3 commits into from
Jan 5, 2026
Merged

Closes #5187: fPIC option for arrow make #5188

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17da384
Closes #5187: fPIC option for arrow make
ajpotts Dec 18, 2025
8067901
change variable name to ARROW_PIC
ajpotts Dec 19, 2025
ddadd5c
unify arrow-shims.mk
ajpotts Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions make/prologue/arrow_shims.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
ARROW_PIC ?=

ARROW_READ_FILE_NAME += $(ARKOUDA_SOURCE_DIR)/parquet/ReadParquet
ARROW_READ_CPP += $(ARROW_READ_FILE_NAME).cpp
ARROW_READ_H += $(ARROW_READ_FILE_NAME).h
Expand Down Expand Up @@ -35,15 +37,15 @@ compile-arrow-cpp:
$(MAKE) compile-arrow-util

compile-arrow-write:
$(CHPL_CXX) -O3 -std=c++17 -c $(ARROW_WRITE_CPP) -o $(ARROW_WRITE_O) \
$(CHPL_CXX) -O3 -std=c++17 $(ARROW_PIC) -c $(ARROW_WRITE_CPP) -o $(ARROW_WRITE_O) \
$(INCLUDE_FLAGS) $(ARROW_SANITIZE)

compile-arrow-read:
$(CHPL_CXX) -O3 -std=c++17 -c $(ARROW_READ_CPP) -o $(ARROW_READ_O) \
$(CHPL_CXX) -O3 -std=c++17 $(ARROW_PIC) -c $(ARROW_READ_CPP) -o $(ARROW_READ_O) \
$(INCLUDE_FLAGS) $(ARROW_SANITIZE)

compile-arrow-util:
$(CHPL_CXX) -O3 -std=c++17 -c $(ARROW_UTIL_CPP) -o $(ARROW_UTIL_O) \
$(CHPL_CXX) -O3 -std=c++17 $(ARROW_PIC) -c $(ARROW_UTIL_CPP) -o $(ARROW_UTIL_O) \
$(INCLUDE_FLAGS) $(ARROW_SANITIZE)

$(ARROW_UTIL_O): $(ARROW_UTIL_CPP) $(ARROW_UTIL_H)
Expand Down