Closes #5187: fPIC option for arrow make #5188
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabraham17
suggested changes
Dec 18, 2025
Contributor
jabraham17
left a comment
jabraham17
left a comment
There was a problem hiding this comment.
The diff does not make sense when compared to #5167. I suggest just applying PIC/ARROW_PIC to that PR, or doing this PR as a commit on top of that one
make/arrow-shims.mk
Outdated
| @@ -0,0 +1,39 @@ | |||
| PIC ?= | |||
Contributor
There was a problem hiding this comment.
I recommend ARROW_PIC as the variable name, to make it clear its only being applied to arrow
ajpotts
force-pushed
the
5187_fPIC_option_for_arrow_make
branch
from
71c0064 to
11c21ba
Compare
ajpotts
force-pushed
the
5187_fPIC_option_for_arrow_make
branch
from
4e96037 to
ddadd5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional PIC flag to the Arrow utility compile rule so packagers can enable
-fPICwhen needed. This allows Spack to pass-fPICwithout carrying a downstream patch, while preserving the default build behavior.Closes #5187: fPIC option for arrow make