Skip to content

Remove dependency of ops on dm-tree #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eb8680 merged 7 commits into from
Aug 14, 2025
Merged

Remove dependency of ops on dm-tree #323

eb8680 merged 7 commits into from
Aug 14, 2025

Conversation

@eb8680
Copy link
Contributor

@eb8680 eb8680 commented Aug 14, 2025 •
edited
Loading

Addresses #296

This PR removes all uses of tree from effectful.ops. It also folds the behavior of ops.syntax._map_structure_and_keys into evaluate.

@eb8680 eb8680 mentioned this pull request Aug 14, 2025
Closed
@eb8680 eb8680 marked this pull request as ready for review August 14, 2025 14:43
@eb8680 eb8680 changed the title Remove dependency on dm-tree Remove dependency of ops on dm-tree Aug 14, 2025
@eb8680
Copy link
Contributor Author

eb8680 commented Aug 14, 2025

The remaining uses of tree are in handlers.torch, handlers.jax and handlers.numpyro. I haven't updated those in this PR because I think the right way to do it is to use the Torch and JAX PyTree APIs and reconcile them with Term, which is a little more involved.

@eb8680 eb8680 requested a review from jfeser August 14, 2025 14:46
@eb8680 eb8680 mentioned this pull request Jul 11, 2025
Closed
3 tasks
jfeser
jfeser approved these changes Aug 14, 2025
View reviewed changes
@eb8680 eb8680 mentioned this pull request Aug 14, 2025
Merged
@eb8680 eb8680 merged commit b332b0c into master Aug 14, 2025
3 checks passed
@eb8680 eb8680 deleted the eb-deprecate-tree branch August 14, 2025 15:41
@eb8680 eb8680 mentioned this pull request Oct 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfeser jfeser jfeser approved these changes

Assignees

No one assigned

Labels

status:awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eb8680 @jfeser