Skip to content

Conversation

@eb8680
Copy link
Contributor

@eb8680 eb8680 commented Aug 14, 2025

Addresses #322

This simple PR adds a case for dataclass in evaluate and syntactic_eq.

@eb8680 eb8680 marked this pull request as ready for review August 14, 2025 15:22
@eb8680 eb8680 changed the base branch from eb-deprecate-tree to master August 14, 2025 15:22
@eb8680 eb8680 requested a review from jfeser August 14, 2025 15:22
@eb8680
Copy link
Contributor Author

eb8680 commented Aug 14, 2025

This should be merged after #323 lands.

@eb8680 eb8680 changed the base branch from master to eb-deprecate-tree August 14, 2025 15:24
Base automatically changed from eb-deprecate-tree to master August 14, 2025 15:41
@eb8680 eb8680 removed the blocked label Aug 14, 2025
@eb8680 eb8680 linked an issue Aug 14, 2025 that may be closed by this pull request
@jfeser jfeser merged commit ff262cb into master Aug 14, 2025
3 checks passed
@jfeser jfeser deleted the eb-eval-dataclass branch August 14, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

evaluate should support dataclasses

3 participants