Skip to content

[action] [PR:24770] Fix the Broadcom supported cmds list in techsupport #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mssonicbld wants to merge 1 commit into
base: 202412
Choose a base branch
from
Open

[action] [PR:24770] Fix the Broadcom supported cmds list in techsupport #1213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 29 additions & 12 deletions tests/show_techsupport/tech_support_cmds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,33 +252,50 @@
]

broadcom_cmd_bcmcmd_xgs = [
'bcmcmd{} -t5 version',
'bcmcmd{} -t5 soc',
'bcmcmd{} -t5 ps',
'bcmcmd{} "l3 nat_ingress show"',
'bcmcmd{} "l3 nat_egress show"',
'bcmcmd{} -t 5 version',
'bcmcmd{} -t 5 ps',
'bcmcmd{} "ipmc table show"',
'bcmcmd{} "multicast show"',
'bcmcmd{} "conf show"',
'bcmcmd{} "fp show"',
'bcmcmd{} "pvlan show"',
'bcmcmd{} "l2 show"',
'bcmcmd{} "l3 intf show"',
'bcmcmd{} "l3 defip show"',
'bcmcmd{} "l3 l3table show"',
'bcmcmd{} "l3 egress show"',
'bcmcmd{} "l3 ecmp egress show"',
'bcmcmd{} "l3 multipath show"',
'bcmcmd{} "l3 ip6host show"',
'bcmcmd{} "l3 ip6route show"',
'bcmcmd{} "mc show"',
'bcmcmd{} "cstat *"',
'bcmcmd{} "mirror show"',
'bcmcmd{} "mirror dest show"',
'bcmcmd{} "port *"',
]

broadcom_cmd_bcmcmd_xgs_soc = [
'bcmcmd{} -t 5 soc',
'bcmcmd{} "conf show"',
'bcmcmd{} "l3 defip show"',
'bcmcmd{} "l3 l3table show"',
'bcmcmd{} "l3 ecmp egress show"',
'bcmcmd{} "l3 multipath show"',
'bcmcmd{} "l3 ip6host show"',
'bcmcmd{} "l3 ip6route show"',
'bcmcmd{} "d chg my_station_tcam"',
]

broadcom_cmd_bcmcmd_xgs_th5 = [
'bcmcmd{} "show config lt raw"',
'bcmcmd{} "l3 route show v6=0"',
'bcmcmd{} "l3 host show v6=0"',
'bcmcmd{} "l3 ecmp show"',
'bcmcmd{} "l3 host show v6=1"',
'bcmcmd{} "l3 route show v6=1"',
'bcmcmd{} "l2 station show"',
'bcmcmd{} "bcmltshell -c \'pt dump -d my_station_tcam\'"',
]

broadcom_cmd_bcmcmd_xgs_nat = [
'bcmcmd{} "l3 nat_ingress show"',
'bcmcmd{} "l3 nat_egress show"',
]

broadcom_cmd_bcmcmd_dnx = [
'bcmcmd{} "l2 show"',
'bcmcmd{} "field group list"',
Expand Down
24 changes: 24 additions & 0 deletions tests/show_techsupport/test_techsupport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,30 @@ def commands_to_check(duthosts, enum_rand_one_per_hwsku_frontend_hostname):
asic_cmds = cmds.broadcom_cmd_bcmcmd_dnx
else:
asic_cmds = cmds.broadcom_cmd_bcmcmd_xgs

# Check if soc commands should be supported
soc_supported = None
try:
soc_supported = duthost.shell(r'bcmcmd bsh -c SOC')
except Exception:
pass
else:
if (soc_supported and soc_supported['rc'] == 0
and 'Unknown command: SOC' not in ' '.join(soc_supported["stdout_lines"])):
asic_cmds += cmds.broadcom_cmd_bcmcmd_xgs_soc
else:
asic_cmds += cmds.broadcom_cmd_bcmcmd_xgs_th5

# Check if nat commands should be supported
nat_supported = None
try:
nat_supported = duthost.shell(r'bcmcmd "show feature" | grep -i nat')
except Exception:
pass
else:
if (nat_supported and nat_supported['rc'] == 0):
asic_cmds += cmds.broadcom_cmd_bcmcmd_xgs_nat

cmds_to_check.update(
{
"broadcom_cmd_bcmcmd":
Expand Down
Loading