[action] [PR:24770] Fix the Broadcom supported cmds list in techsupport#1213
Open
mssonicbld wants to merge 1 commit into
Open
[action] [PR:24770] Fix the Broadcom supported cmds list in techsupport#1213mssonicbld wants to merge 1 commit into
mssonicbld wants to merge 1 commit into
Conversation
Due to the changes in [PR#4542](sonic-net/sonic-utilities#4542), the show_techsupport test needs to check Broadcom commands based on the chip module. The fix separates non-TH5 and TH5 commands into different lists (broadcom_cmd_bcmcmd_xgs_soc and broadcom_cmd_bcmcmd_xgs_th5) and combines with the common commands list (broadcom_cmd_bcmcmd_xgs) before checking. <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 - [ ] 202512 - [ ] 202605 ### Approach #### What is the motivation for this PR? To address show_techsupport test failure after [PR#4542](sonic-net/sonic-utilities#4542) is merged. #### How did you do it? #### How did you verify/test it? Run show_techsupport test on the DUTs with Broadcom non-TH5 and TH5 chipsets, and verify no failed cases. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#24770 |
Collaborator
Author
|
/azp run |
12 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
This cherry pick PR has been opened for more than 3 days. The mssonicbld will attempt to retry. ---Powered by SONiC BuildBot
|
Collaborator
Author
|
/azpw retry |
Collaborator
Author
|
@r12f The cherry pick PR didn't pass PR checker after retry. Left a comment in original PR sonic-net/sonic-mgmt#24770 to notify author. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the changes in PR#4542, the show_techsupport test needs to check Broadcom commands based on the chip module.
The fix separates non-TH5 and TH5 commands into different lists (broadcom_cmd_bcmcmd_xgs_soc and broadcom_cmd_bcmcmd_xgs_th5) and combines with the common commands list (broadcom_cmd_bcmcmd_xgs) before checking.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To address show_techsupport test failure after PR#4542 is merged.
How did you do it?
How did you verify/test it?
Run show_techsupport test on the DUTs with Broadcom non-TH5 and TH5 chipsets, and verify no failed cases.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com