Skip to content

Make JsonConstructor DataSource parameter nullable to match property annotation #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronburtle wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Make JsonConstructor DataSource parameter nullable to match property annotation #3526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d069e54
Make JsonConstructor DataSource parameter nullable to match property …
aaronburtle May 7, 2026
351ac97
Update DataSource parameter doc to reflect nullable annotation
aaronburtle May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Config/ObjectModel/RuntimeConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,14 +310,14 @@ public bool RemoveGeneratedAutoentityNameFromDataSourceName(string entityName)
/// To be used when setting up from cli json scenario.
/// </summary>
/// <param name="Schema">schema for config.</param>
/// <param name="DataSource">Default datasource.</param>
/// <param name="DataSource">Default datasource. May be null for root configs that use <paramref name="DataSourceFiles"/> and delegate the data source to child configs.</param>
/// <param name="Entities">Entities</param>
/// <param name="Runtime">Runtime settings.</param>
/// <param name="DataSourceFiles">List of datasource files for multiple db scenario. Null for single db scenario.</param>
[JsonConstructor]
public RuntimeConfig(
string? Schema,
DataSource DataSource,
DataSource? DataSource,
RuntimeEntities Entities,
Comment thread
aaronburtle marked this conversation as resolved.
Comment thread
aaronburtle marked this conversation as resolved.
RuntimeAutoentities? Autoentities = null,
RuntimeOptions? Runtime = null,
Expand Down