Make JsonConstructor DataSource parameter nullable to match property annotation#3526
Open
aaronburtle wants to merge 2 commits intomainfrom
Open
Make JsonConstructor DataSource parameter nullable to match property annotation#3526aaronburtle wants to merge 2 commits intomainfrom
aaronburtle wants to merge 2 commits intomainfrom
Conversation
aaronburtle
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
RubenCerna2079,
anushakolan,
rusamant,
sourabh1007,
souvikghosh04,
stuartpa and
vadeveka
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns RuntimeConfig’s [JsonConstructor] parameter nullability with the DataSource property’s DataSource? annotation, allowing JSON deserialization to omit data-source (e.g., for root configs that use data-source-files).
Changes:
- Updated the
RuntimeConfigJSON constructor to acceptDataSource?instead ofDataSource.
Aniruddh25
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #3525
What is this change?
Small change, DataSource to DataSource? in the JsonConstructor for RuntimeConfig, and update comment to match.
How was this tested?
Run against regular test suite.