Skip to content

[Storage] az storage share close-handle: Fix failing to close file handle when in delete pending state #32697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hualiangxu wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −0
Open

[Storage] az storage share close-handle: Fix failing to close file handle when in delete pending state #32697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/azure-cli/azure/cli/command_modules/storage/operations/fileshare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,18 @@ def _get_client(client, kwargs):
dir_client = client.get_directory_client(directory_path=total_path)
exists = False
from azure.core.exceptions import ClientAuthenticationError
from azure.core.exceptions import ResourceExistsError
try:
exists = dir_client.exists()
except ClientAuthenticationError:
exists = False
except ResourceExistsError as ex:
if hasattr(ex, "error_code") and ex.error_code == "DeletePending":
# translate delete pending flag as file/dir not exists.
exists = False
else:
raise ex

if not exists:
dir_client = client.get_directory_client(directory_path=directory_path)
client = dir_client.get_file_client(file_name=file_name)
Expand Down