Skip to content

Fix iPad crash caused by vote menu from toolbar #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfsm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix iPad crash caused by vote menu from toolbar #1226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions App/View Controllers/Posts/PostsPageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,13 +563,13 @@ final class PostsPageViewController: ViewController {
}()


private func actionsItem() -> UIBarButtonItem {
private lazy var actionsItem: UIBarButtonItem = {
let buttonItem = UIBarButtonItem(title: "Menu", image: UIImage(named: "steamed-ham"), menu: threadActionsMenu())
if #available(iOS 16.0, *) {
buttonItem.preferredMenuElementOrder = .fixed
}
return buttonItem
}
}()

private func refetchPosts() {
guard case .specific(let pageNumber)? = page else {
Expand Down Expand Up @@ -1042,7 +1042,7 @@ final class PostsPageViewController: ViewController {
// update toolbar so menu reflects new bookmarked state
var newItems = postsView.toolbarItems
newItems.removeLast()
newItems.append(actionsItem())
newItems.append(actionsItem)
postsView.toolbarItems = newItems
}
} catch {
Expand Down Expand Up @@ -1148,7 +1148,7 @@ final class PostsPageViewController: ViewController {
present(actionSheet, animated: false)

if let popover = actionSheet.popoverPresentationController {
popover.barButtonItem = actionsItem()
popover.barButtonItem = actionsItem
}
}
}
Expand Down Expand Up @@ -1540,7 +1540,7 @@ final class PostsPageViewController: ViewController {
postsView.toolbarItems = [
settingsItem, .flexibleSpace(),
backItem, .fixedSpace(spacer), currentPageItem, .fixedSpace(spacer), forwardItem,
.flexibleSpace(), actionsItem()]
.flexibleSpace(), actionsItem]

let longPress = UILongPressGestureRecognizer(target: self, action: #selector(didLongPressOnPostsView))
longPress.delegate = self
Expand Down
Loading