Use dynamic user agent instead of hardcoded Chrome version#28
Open
pirate wants to merge 1 commit into
Open
Conversation
The headless-detection-bypass UA in ublock/modalcloser/istilldontcareaboutcookies tests was a literal Chrome/120.0.0.0 string, so the fixtures aged with every Chrome upgrade and risked drifting noticeably from the real browser's UA. Read the actual UA via browser.userAgent() and strip the "Headless" / "HeadlessChrome" tokens — same fingerprint-evasion effect, no baked-in version to keep up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hardcoded user agent strings with dynamically generated ones derived from the actual browser instance. This prevents the user agent from becoming stale when the browser version is upgraded.
Key Changes
abx_plugins/plugins/modalcloser/tests/test_modalcloser.pyabx_plugins/plugins/istilldontcareaboutcookies/tests/test_istilldontcareaboutcookies.pyabx_plugins/plugins/ublock/tests/test_ublock.pyImplementation Details
browser.userAgent()'HeadlessChrome/'with'Chrome/'' Headless'suffixhttps://claude.ai/code/session_01Qrpaidw2umKZjG5zGQZrkv
Summary by cubic
Use a dynamic user agent in test fixtures instead of a hardcoded Chrome/120 string to avoid stale UAs after browser upgrades and keep the headless-bypass working. We read
browser.userAgent(), replaceHeadlessChrome/withChrome/, remove theHeadlesssuffix, then callpage.setUserAgent()in tests formodalcloser,istilldontcareaboutcookies, andublock.Written for commit c281077. Summary will update on new commits. Review in cubic