Skip to content

Use dynamic user agent instead of hardcoded Chrome version #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pirate wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

Use dynamic user agent instead of hardcoded Chrome version #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion abx_plugins/plugins/istilldontcareaboutcookies/tests/test_istilldontcareaboutcookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,9 @@ def check_cookie_consent_visibility(
{{ puppeteer, browserWSEndpoint: '{cdp_url}' }},
async (browser) => {{
const page = await browser.newPage();
await page.setUserAgent('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36');
const browserUa = await browser.userAgent();
const realisticUa = browserUa.replace('HeadlessChrome/', 'Chrome/').replace(' Headless', '');
await page.setUserAgent(realisticUa);
await page.setViewport({{ width: 1440, height: 900 }});

console.error('Navigating to {test_url}...');
Expand Down
7 changes: 5 additions & 2 deletions abx_plugins/plugins/modalcloser/tests/test_modalcloser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,11 @@ def test_hides_cookie_consent_on_filmin():
});

const page = await browser.newPage();
// Set real user agent to bypass headless detection
await page.setUserAgent('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36');
// Set a non-headless UA derived from the actual browser to bypass headless detection
// without baking a Chrome version into source that will go stale on upgrade.
const browserUa = await browser.userAgent();
const realisticUa = browserUa.replace('HeadlessChrome/', 'Chrome/').replace(' Headless', '');
await page.setUserAgent(realisticUa);
await page.setViewport({ width: 1440, height: 900 });

console.error('Navigating to filmin.es...');
Expand Down
4 changes: 3 additions & 1 deletion abx_plugins/plugins/ublock/tests/test_ublock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,9 @@ def check_ad_blocking(cdp_url: str, test_url: str, env: dict, script_dir: Path)
{{ puppeteer, browserWSEndpoint: '{cdp_url}' }},
async (browser) => {{
const page = await browser.newPage();
await page.setUserAgent('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36');
const browserUa = await browser.userAgent();
const realisticUa = browserUa.replace('HeadlessChrome/', 'Chrome/').replace(' Headless', '');
await page.setUserAgent(realisticUa);
await page.setViewport({{ width: 1440, height: 900 }});

// Track network requests
Expand Down
Loading