Skip to content

fix(cli): address PR review comments - cross-platform time, formatting, unused var #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wax911 merged 2 commits into from
Jan 9, 2026
Merged

fix(cli): address PR review comments - cross-platform time, formatting, unused var #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f2c50
Initial plan
Copilot Jan 7, 2026
7fda899
fix(cli): address PR review comments - cross-platform time, formattin…
Copilot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tools/stackctl_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import shutil
import subprocess
import sys
import time
from dataclasses import dataclass
from pathlib import Path
from typing import Dict, List, Optional, Tuple
Expand Down Expand Up @@ -255,7 +256,7 @@ def deploy(


@APP.command()
def logs(services: List[str] = typer.Argument(None, help="Services to follow (default preset)") ):
def logs(services: List[str] = typer.Argument(None, help="Services to follow (default preset)")):
"""Follow logs for services (docker service logs -f)."""
svcs = services or DEFAULT_LOG_SERVICES
for svc in svcs:
Expand Down Expand Up @@ -363,7 +364,7 @@ def env_recreate(
if resp.lower() not in ("y", "yes"):
skipped.append(str(envp))
continue
backup = envp.with_suffix(envp.suffix + f".bak.{int(os.times().elapsed)}")
backup = envp.with_suffix(envp.suffix + f".bak.{int(time.time())}")
shutil.copy2(envp, backup)
shutil.copy2(ex, envp)
overwritten.append(str(envp))
Expand Down Expand Up @@ -400,7 +401,7 @@ def secrets_decrypt(
output_path.parent.mkdir(parents=True, exist_ok=True)
# Write directly to file to avoid secrets in stdout
with output_path.open("wb") as fh:
proc = subprocess.run(["sops", "-d", str(input_path)], check=True, stdout=fh)
subprocess.run(["sops", "-d", str(input_path)], check=True, stdout=fh)
console.print(f"[green]Decrypted[/green] -> {output_path}")


Expand Down
Loading