fix(cli): address PR review comments - cross-platform time, formatting, unused var#374
Merged
Merged
Conversation
…g, unused var Co-authored-by: wax911 <7859175+wax911@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Python stackctl CLI with overlays and SOPS support
fix(cli): address PR review comments - cross-platform time, formatting, unused var
Jan 7, 2026
wax911
approved these changes
Jan 9, 2026
wax911
added a commit
that referenced
this pull request
Mar 12, 2026
…g, unused var (#374) * Initial plan * fix(cli): address PR review comments - cross-platform time, formatting, unused var Co-authored-by: wax911 <7859175+wax911@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wax911 <7859175+wax911@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on
tools/stackctl_cli.pyfrom PR #322: cross-platform compatibility issue, formatting nitpick, and unused variable.Changes
os.times().elapsedwithtime.time()for backup timestamp generation (line 366)logs()function signature (line 258)procvariable insecrets_decrypt()(line 403)Context
The
os.times().elapsedfield is not available on all platforms and raisesAttributeErroron Windows. Usingtime.time()provides consistent cross-platform behavior for generating unique backup filenames.The
set +e/set -epattern mentioned in review was already fixed in commit a0bd17d.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.