Skip to content

PWGCF : Femtouniverse -- Fixing bug in dphi calculation #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
victor-gonzalez merged 4 commits into from
Apr 16, 2024
Merged

PWGCF : Femtouniverse -- Fixing bug in dphi calculation #5643

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6f746c
PWGCF : Femtouniverse -- Fixing bug in dphi calculation
prchakra Apr 16, 2024
19ee9b8
PWGCF : Femtouniverse -- Fixing bug in dphi calculation
prchakra Apr 16, 2024
1144180
Update FemtoUniverseDetaDphiStar.h
prchakra Apr 16, 2024
3c9cd5d
Update FemtoUniverseDetaDphiStar.h
prchakra Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
/// \brief FemtoUniverseDetaDphiStar - Checks particles for the close pair rejection.
/// \author Laura Serksnyte, TU München, laura.serksnyte@tum.de
/// \author Zuzanna Chochulska, WUT Warsaw & CTU Prague, zchochul@cern.ch
/// \author Pritam Chakraborty, WUT Warsaw, pritam.chakraborty@cern.ch

#ifndef PWGCF_FEMTOUNIVERSE_CORE_FEMTOUNIVERSEDETADPHISTAR_H_
#define PWGCF_FEMTOUNIVERSE_CORE_FEMTOUNIVERSEDETADPHISTAR_H_
Expand Down Expand Up @@ -377,7 +378,10 @@ class FemtoUniverseDetaDphiStar
// End: Get the charge from cutcontainer using masks
float pt = part.pt();
for (size_t i = 0; i < 9; i++) {
tmpVec.push_back(phi0 - std::asin(0.3 * charge * 0.1 * magfield * tmpRadiiTPC[i] * 0.01 / (2. * pt)));
double arg = 0.3 * charge * magfield * tmpRadiiTPC[i] * 0.01 / (2. * pt);
if (abs(arg) < 1.0) {
tmpVec.push_back(phi0 - std::asin(arg));
}
}
}

Expand Down Expand Up @@ -426,12 +430,15 @@ class FemtoUniverseDetaDphiStar
float charge1 = GetCharge(part1);
float charge2 = GetCharge(part2);

double deltaphiconstFD = 0.3 * 0.1 * 0.01 / 2;
double deltaphiconstFD = 0.3 / 2;
// double deltaphiconstAF = 0.15;
double afsi0b = deltaphiconstFD * magfield * charge1 * ChosenRadii / part1.pt();
double afsi1b = deltaphiconstFD * magfield * charge2 * ChosenRadii / part2.pt();
double dphis = 0.0;

double dphis = part2.phi() - part1.phi() + TMath::ASin(afsi1b) - TMath::ASin(afsi0b);
if (abs(afsi0b) < 1.0 && abs(afsi0b) < 1.0) {
Copy link
Collaborator

@vkucera vkucera Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug

Copy link
Collaborator

@vkucera vkucera Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prchakra @victor-gonzalez Still there

Copy link
Collaborator Author

@prchakra prchakra Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fixed already

O2Physics/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h

Line 913 in c6685b5

if (std::abs(afsi0b) < 1.0 && std::abs(afsi0b) < 1.0) {

Copy link
Collaborator

@vkucera vkucera Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fixed already

O2Physics/PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h

Line 913 in c6685b5

if (std::abs(afsi0b) < 1.0 && std::abs(afsi0b) < 1.0) {

No it wasn't. You are just quoting the bug.

Copy link
Collaborator Author

@prchakra prchakra Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed #14106

Copy link
Collaborator

@vkucera vkucera Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

dphis = part2.phi() - part1.phi() + TMath::ASin(afsi1b) - TMath::ASin(afsi0b);
}
return dphis;
}
};
Expand Down