PWGCF : Femtouniverse -- Fixing bug in dphi calculation #5643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra factor of 0.1 that was scaling the magnetic field is removed. However, after removing this factor, the asin(<arg>) function for calculating dphi was blowing up at certain (mostly higher) values of radii. This is also taken care of by only allowing abs(<arg>) < 1.0.
prchakra
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
The extra factor of 0.1 that was scaling the magnetic field is removed. However, after removing this factor, the asin() function for calculating dphi was blowing up at certain (mostly higher) values of radii. This is also taken care of by only allowing abs() < 1.0.
Collaborator
|
Error while checking build/O2Physics/o2 for 19ee9b8 at 2024-04-16 20:04: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 1144180 at 2024-04-16 20:47: Full log here. |
victor-gonzalez
approved these changes
Apr 16, 2024
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
…#5643) * PWGCF : Femtouniverse -- Fixing bug in dphi calculation The extra factor of 0.1 that was scaling the magnetic field is removed. However, after removing this factor, the asin(<arg>) function for calculating dphi was blowing up at certain (mostly higher) values of radii. This is also taken care of by only allowing abs(<arg>) < 1.0. * PWGCF : Femtouniverse -- Fixing bug in dphi calculation The extra factor of 0.1 that was scaling the magnetic field is removed. However, after removing this factor, the asin() function for calculating dphi was blowing up at certain (mostly higher) values of radii. This is also taken care of by only allowing abs() < 1.0. * Update FemtoUniverseDetaDphiStar.h * Update FemtoUniverseDetaDphiStar.h
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
…#5643) * PWGCF : Femtouniverse -- Fixing bug in dphi calculation The extra factor of 0.1 that was scaling the magnetic field is removed. However, after removing this factor, the asin(<arg>) function for calculating dphi was blowing up at certain (mostly higher) values of radii. This is also taken care of by only allowing abs(<arg>) < 1.0. * PWGCF : Femtouniverse -- Fixing bug in dphi calculation The extra factor of 0.1 that was scaling the magnetic field is removed. However, after removing this factor, the asin() function for calculating dphi was blowing up at certain (mostly higher) values of radii. This is also taken care of by only allowing abs() < 1.0. * Update FemtoUniverseDetaDphiStar.h * Update FemtoUniverseDetaDphiStar.h
vkucera
reviewed
Nov 30, 2025
| double dphis = 0.0; | ||
|
|
||
| double dphis = part2.phi() - part1.phi() + TMath::ASin(afsi1b) - TMath::ASin(afsi0b); | ||
| if (abs(afsi0b) < 1.0 && abs(afsi0b) < 1.0) { |
Collaborator
Author
There was a problem hiding this comment.
Was fixed already
Collaborator
There was a problem hiding this comment.
Was fixed already
No it wasn't. You are just quoting the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra factor of 0.1 that was scaling the magnetic field is removed.
However, after removing this factor, the asin() function for calculating dphi was blowing up at certain (mostly higher) values of radii. This is also taken care of by only allowing abs() < 1.0.