[Infrastructure] O2 linter: Remove prefix exception for constexpr constants #13518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
vkucera
changed the title
vkucera
requested review from
a team,
alibuild,
ddobrigk,
iarsene,
jgrosseo and
ktf
as code owners
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception existed only to allow names suggested by the
[runtime/arrays]error message in cpplint:However, cpplint accepts CamelCase without the
kprefix as well, making the exception unnecessary and allowing to be fully consistent with the O2 naming conventions.O2 linter mentions the exception in the error message but doesn't specify what a "special constant" is which has confused many people. Removing the exception prevents this confusion.