Remove prefix exception for constexpr constants

Author: vkucera

.clang-tidy

@@ -4,10 +4,9 @@ CheckOptions:
   - { key: readability-identifier-naming.ClassMemberPrefix, value: m }
   - { key: readability-identifier-naming.ConceptCase, value: CamelCase }
   - { key: readability-identifier-naming.ConstexprVariableCase, value: CamelCase }
-  - { key: readability-identifier-naming.ConstexprVariableIgnoredRegexp, value: "^k[A-Z][a-zA-Z0-9]*$" }  # Allow "k" prefix.
   - { key: readability-identifier-naming.EnumCase, value: CamelCase }
   - { key: readability-identifier-naming.EnumConstantCase, value: CamelCase }
-  - { key: readability-identifier-naming.EnumConstantIgnoredRegexp, value: "^k?[A-Z][a-zA-Z0-9_]*$" }  # Allow "k" prefix and underscores.
+  - { key: readability-identifier-naming.EnumConstantIgnoredRegexp, value: "^k?[A-Z][a-zA-Z0-9_]*[^_]$" }  # Allow "k" prefix and non-trailing underscores in PDG names.
   - { key: readability-identifier-naming.FunctionCase, value: camelBack }
   - { key: readability-identifier-naming.MacroDefinitionCase, value: UPPER_CASE }
   - { key: readability-identifier-naming.MacroDefinitionIgnoredRegexp, value: "^[A-Z][A-Z0-9_]*_$" }  # Allow the trailing underscore in header guards.

Scripts/o2_linter.py

@@ -989,7 +989,7 @@ class TestNameConstant(TestSpec):
 
     name = "name/constexpr-constant"
     message = (
-        'Use UpperCamelCase for names of constexpr constants. Names of special constants may be prefixed with "k".'
+        'Use UpperCamelCase for names of constexpr constants.'
     )
     rationale = rationale_names
     references = references_names
@@ -1013,8 +1013,6 @@ def test_line(self, line: str) -> bool:
             return True
         constant_name = match.group(4)
         # The actual test comes here.
-        if constant_name.startswith("k") and len(constant_name) > 1:  # exception for special constants
-            constant_name = constant_name[1:]  # test the name without "k"
         return is_upper_camel_case(constant_name)