Skip to content

[Common] Improved background characterisation methods for dimuon DCA #13432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddobrigk merged 1 commit into from
Oct 21, 2025
Merged

[Common] Improved background characterisation methods for dimuon DCA #13432

ddobrigk merged 1 commit into from
Oct 21, 2025

Conversation

@ppoava
Copy link
Contributor

@ppoava ppoava commented Oct 17, 2025

Two main things were improved or added:

  • Dimuon mass cut configurables (no 'magic number' anymore; cut can be used to study region outside J/psi peak)
  • Same-sign DCA distributions

@ppoava ppoava requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners October 17, 2025 12:08
@github-actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

O2 linter results: ❌ 69 errors, ⚠️ 91 warnings, 🔕 0 disabled

@ppoava ppoava force-pushed the dev_branch branch 2 times, most recently from 707762c to e1e8b66 Compare October 20, 2025 07:41
@alibuild
Copy link
Collaborator

alibuild commented Oct 20, 2025

Error while checking build/O2Physics/o2 for e1e8b66 at 2025-10-20 10:12:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13432-slc9_x86-64/0/Common/Tasks/qaMuon.cxx:1266:23: error: loop variable 'muon1' creates a copy from type 'const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >' [-Werror=range-loop-construct]
/sw/SOURCES/O2Physics/13432-slc9_x86-64/0/Common/Tasks/qaMuon.cxx:1287:27: error: loop variable 'muon2' creates a copy from type 'const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >' [-Werror=range-loop-construct]
/sw/SOURCES/O2Physics/13432-slc9_x86-64/0/Common/Tasks/qaMuon.cxx:1309:23: error: loop variable 'muon1' creates a copy from type 'const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >' [-Werror=range-loop-construct]
/sw/SOURCES/O2Physics/13432-slc9_x86-64/0/Common/Tasks/qaMuon.cxx:1334:27: error: loop variable 'muon2' creates a copy from type 'const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >, o2::soa::JoinFull<o2::aod::Hash<197928243>, o2::soa::Table<o2::aod::Hash<15601895>, o2::aod::Hash<4180572075>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1815461783>, o2::aod::Hash<197928243>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<2418519273>, o2::soa::Table<o2::aod::Hash<2000900833>, o2::aod::Hash<2779707857>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1154255962>, o2::aod::Hash<2418519273>, o2::aod::Hash<1926198916> > > >' [-Werror=range-loop-construct]
ninja: build stopped: subcommand failed.

Full log here.

@ppoava
[Common] Improved background characterisation methods for dimuon DCA
b0ce03f 
Two main things were improved or added:
- Dimuon mass cut configurables (no 'magic number' anymore; cut can be used to study region outside J/psi peak)
- Same-sign DCA distributions
@ppoava ppoava closed this Oct 20, 2025
@ppoava ppoava reopened this Oct 20, 2025
@ppoava ppoava closed this Oct 20, 2025
@ppoava ppoava reopened this Oct 20, 2025
@ddobrigk ddobrigk merged commit e4b9b79 into AliceO2Group:master Oct 21, 2025
24 of 31 checks passed
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@ppoava @ThePhDane
[Common] Improved background characterisation methods for dimuon DCA (A…
e59393b 
…liceO2Group#13432)
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@ppoava
[Common] Improved background characterisation methods for dimuon DCA (A…
b0fff2e 
…liceO2Group#13432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigk ddobrigk ddobrigk approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

common

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ppoava @alibuild @ddobrigk