Skip to content

Conversation

@PaolaVT
Copy link
Contributor

@PaolaVT PaolaVT commented Sep 14, 2025

This update introduces new histograms to monitor which events and tracks pass the selection criteria. The histograms are filled after event-level and track-level cuts and are meant for validation and debugging.
Additionally, code improvements were made by replacing hard-coded bin indices with enums and using std::hypot for better readability and precision.

@github-actions
Copy link

github-actions bot commented Sep 14, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title The issue with the macOS-arm checks has been resolved [PWGLF] The issue with the macOS-arm checks has been resolved Sep 14, 2025
maciacco
maciacco previously approved these changes Sep 14, 2025
@maciacco maciacco enabled auto-merge (squash) September 14, 2025 20:37
@vkucera
Copy link
Collaborator

vkucera commented Sep 15, 2025

@PaolaVT Which issue are you referring to in the PR title?

@PaolaVT
Copy link
Contributor Author

PaolaVT commented Sep 15, 2025

@vkucera The macOS and macOS-arm checks failed due to an undeclared variable in the code

@PaolaVT PaolaVT closed this Sep 15, 2025
auto-merge was automatically disabled September 15, 2025 19:14

Pull request was closed

@vkucera
Copy link
Collaborator

vkucera commented Sep 15, 2025

@vkucera The macOS and macOS-arm checks failed due to an undeclared variable in the code

That failure does not seem to be related to the actual purpose of this PR.
Please change the PR title according to the contribution instructions.

@PaolaVT PaolaVT changed the title [PWGLF] The issue with the macOS-arm checks has been resolved [PWGLF] Implement validation histograms and code cleanup Sep 15, 2025
@PaolaVT
Copy link
Contributor Author

PaolaVT commented Sep 15, 2025

@vkucera The macOS and macOS-arm checks failed due to an undeclared variable in the code

That failure does not seem to be related to the actual purpose of this PR. Please change the PR title according to the contribution instructions.

Thanks a lot for the suggestions, I have implemented them to improve the analysis accordingly.

@maciacco maciacco enabled auto-merge (squash) September 16, 2025 06:41
@maciacco maciacco merged commit c255dac into AliceO2Group:master Sep 16, 2025
33 of 35 checks passed
jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
…p#12981)

Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
…p#12981)

Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
…p#12981)

Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
…p#12981)

Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
…p#12981)

Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants