-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGLF] Implement validation histograms and code cleanup #12981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 0 errors, |
|
@PaolaVT Which issue are you referring to in the PR title? |
|
@vkucera The macOS and macOS-arm checks failed due to an undeclared variable in the code |
Pull request was closed
That failure does not seem to be related to the actual purpose of this PR. |
Thanks a lot for the suggestions, I have implemented them to improve the analysis accordingly. |
…p#12981) Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
…p#12981) Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
…p#12981) Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
…p#12981) Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
…p#12981) Co-authored-by: Paola Vargas Torres <paolavargas@MacBook-Air-de-Paola.local>
This update introduces new histograms to monitor which events and tracks pass the selection criteria. The histograms are filled after event-level and track-level cuts and are meant for validation and debugging.
Additionally, code improvements were made by replacing hard-coded bin indices with enums and using std::hypot for better readability and precision.