Skip to content

Conversation

@lubynets
Copy link
Contributor

Enabled filling a clean kaon sample for TPC PID NN training (in addition to existing samples of electrons, pions and protons).

@github-actions
Copy link

github-actions bot commented Sep 10, 2025

O2 linter results: ❌ 383 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title TPC PID: fill clean kaon sample from Omega decay [PWGDQ,PWGLF,DPG] TPC PID: fill clean kaon sample from Omega decay Sep 10, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 0346322 at 2025-09-10 21:45:

No log files found

Full log here.

@lubynets lubynets marked this pull request as draft September 23, 2025 16:05
@amaringarcia
Copy link
Contributor

Dear @romainschotter , all,
can we advance in this pull request? In understand that the changes introduced in LFStrangenessTable are done in a way that they do not interfere for the standard use , while they allow to do selections for clean kaon samples in a region of phase space where we do not have them yet.
best regards,
Ana

@romainschotter
Copy link
Collaborator

Hi @amaringarcia ! I completely agree with you. The changes in the strangeness data model should not interfere with anyone's work.
From what I understand, the v0selector task is mainly used to obtain clean samples of various species: electrons from photon conversions, pions from K0s, protons from Lambda and kaons from Omegas. If that is correct, I am curious: wouldn’t it make more sense for the task to be located in LF or EM rather than in DQ?

@amaringarcia
Copy link
Contributor

Good morning @romainschotter, I think the reasons are historical, the J/psi analysers started very early on (pp @sqrt(s)= 7TeV) to use clean samples of electrons for electron PID efficiency. From my point of view, we could do a two stage move, the commit is approve as it is as we would like to add the kaons as soon as possible for the NN training, and in the mean time we check with the different players (DQ, LF,...) if a common v0selector can be centralized. Indeed many people use clean samples of identified particles and a common development stored in a central directory makes sense.

@lubynets lubynets marked this pull request as ready for review September 26, 2025 08:07
@romainschotter
Copy link
Collaborator

Hi @amaringarcia !
I’m not sure it’s necessary to have a centralized task for studying V0. My point is more about where the task should be located: as far as I understand, DQ focuses on quarkonia such as J/psi, which do not follow a V0 decay topology (since they don’t have a very displaced decay vertex).
In any case, I will not further delay the PR and I will approve the changes in the data model.
Still, I would suggest considering moving the task to a directory more directly related to V0/cascade studies, such as LF or EM.

@iarsene
Copy link
Collaborator

iarsene commented Sep 29, 2025

Hi @romainschotter, I think that unless we find a concrete reason for which to move this task to a different PWG directory, we should keep it here. In DQ, we are the main "consumer" of this task, so it makes sense that we maintain it and change it according to our needs.

@iarsene iarsene enabled auto-merge (squash) September 29, 2025 06:57
@iarsene iarsene merged commit 79ae1da into AliceO2Group:master Sep 29, 2025
15 of 17 checks passed
@romainschotter
Copy link
Collaborator

Hi @romainschotter, I think that unless we find a concrete reason for which to move this task to a different PWG directory, we should keep it here. In DQ, we are the main "consumer" of this task, so it makes sense that we maintain it and change it according to our needs.

Hi @iarsene!
Sorry for the confusion! I didn't mean to suggest moving the task. What I had in mind was rather making a copy of the task in another PWG. Anyway.

@lubynets lubynets deleted the pidTpc branch September 29, 2025 14:38
jmunozme pushed a commit to jmunozme/O2Physics that referenced this pull request Oct 3, 2025
…liceO2Group#12947)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
…liceO2Group#12947)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
…liceO2Group#12947)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
…liceO2Group#12947)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
…liceO2Group#12947)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants