[PWGCF] - FemtoDream: Cascade Update #12820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also adding the CascadeCascade pair task - including before and after selection plots for all species
- Added OmegaMinus PDG code in the histogram class - Added naming scheme for Cascade-Cascade daughters - Some other small fixes
gmantzar
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 311 errors, |
--> later the option needs to be added to switch, in case someone wants on analyse two different cascades
Comment on lines
32
to
33
| o2physics_add_dpl_workflow(femtodream-pair-casdcade-cascade | ||
| SOURCES femtoDreamPairTaskCascadeCascade.cxx |
Collaborator
There was a problem hiding this comment.
Please, fix the linter error and don't use Task in the name of the source file, it is implicit in the directory
Comment on lines
11
to
13
| /// \file femtoDreamPairTaskCascadeCascade.cxx | ||
| /// \brief Tasks that reads the track tables used for the pairing and builds pairs of two cascades | ||
| /// \author Andi Mathis, Anton Riedel, Georgios Mantzaridis, Oton Vazquez Doce. |
Collaborator
There was a problem hiding this comment.
Please, rename the file according to the previous comment
If an empty line is left after the copyright notice and before the \file directive, the linter error should go away
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comments
I'am ready to approve it once they are addressed
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
Co-authored-by: georgios <georgios@georgioss-MacBook-Pro-M2.local>
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
Co-authored-by: georgios <georgios@georgioss-MacBook-Pro-M2.local>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Co-authored-by: georgios <georgios@georgioss-MacBook-Pro-M2.local>
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Co-authored-by: georgios <georgios@georgioss-MacBook-Pro-M2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--> Tested and working but missing the CPR (and the pair cleaning). Needs to be done!