[PWGCF] A correlation task for triplets (track-track-v0) in Pb–Pb collisions

[wrzesaCERN]

Adding a new task for 3-body femtoscopic studies (2 tracks and V0) in PbPb
Adding back the 3-tracks task to the cmakelists

[github-actions]

O2 linter results: ❌ 58 errors, ⚠️ 0 warnings, 🔕 0 disabled

[victor-gonzalez]

Please, keep it as draft for the time being for not wasting CI resources

New source files should enter without linter errors and should not produce linter errors in the CMakeLists.txt files

@ariedel-cern is it really needed a new task just because the analysis move from pp to PbPb? Should not be enough to use a few appropriate configurables? Replicating the full task just because it is a different system does not seem the right way

[lauraser]

Hi @victor-gonzalez, as people from different groups will conduct the analysis, we prefer to keep it separated for now. While the code at some point, indeed, can be merged, it should first be tested on Hyperloop and finalised. The analysis of PbPb is very new, and it is not clear yet how many actual changes will be required to be made to the task in the upcoming months. While pp analysis is almost finalised and in preparation for the paper proposal. I would really like to avoid any possibility of bugs that might be missed. This already happened during QM preliminaries when someone tested their code to work for their case but it completely destroyed my analysis. Would it be fine for you if, for now, we keep the analyses separate?

[victor-gonzalez]

OK! Let's move forward with this!
I agree on keeping a separate task for PbPb analysis for the time being

As this is now a new task, new source code, it has to adhere to the linter and MegaLinter recommendation. They are really useful for catching tricky mistakes, increase the readability of the code, improve its maintenance and easy its evolution. The recommendations were not available at the time of FemtoDream creation but now they are, and are really useful.

@wrzesaCERN could you please take care of linter and MegaLinster errors on the new source files? Also on the part of CMakeLists.txt affecting the new source files. Once this is achieved we can move the PR to ready for review.
Thanks!

[wrzesaCERN]

Dear Victor @victor-gonzalez,

Thank you for feedback and sorry for the delay, but I didn’t have the possibility to easily test the new changes before.
I have solved all the errors within my task (the remaining O2 linear issue does not concern the main file which I added).

I hope now is fine.
Best regards,
Wioleta Rzęsa

[victor-gonzalez]

Dear Victor @victor-gonzalez,

Thank you for feedback and sorry for the delay, but I didn’t have the possibility to easily test the new changes before. I have solved all the errors within my task (the remaining O2 linear issue does not concern the main file which I added).

I hope now is fine. Best regards, Wioleta Rzęsa

Thanks!
I still believe you should be able to fix the CMakeLists.txt linter error which affects to the new file
But OK I leave it to @lauraser to say the final word and approve it

[victor-gonzalez]

If you want your executable named as you said (femtodream-triplet-track-track-track-pb-pb), follow linter recommendation on how to name your source file

[lauraser]

This is not part of her PR, the PbPb track track track task was done a few months ago by my student. I would suggest that Wiola fix only the linter related to her task.

[victor-gonzalez]

This is not part of her PR, the PbPb track track track task was done a few months ago by my student. I would suggest that Wiola fix only the linter related to her task.

But it is now when it enters in the build machinery so is the proper time for renaming it or rename the executable name if so is decided

[victor-gonzalez]

Same here

[victor-gonzalez]

Same here

Although it seems this is a false positive or the linter getting out of sync @vkucera

[lauraser]

I think the linter wants a hyphen at every location, where the upper case letter is. So it might want the task to be called femto-dream if femtoDream is in the source name.

[lauraser]

ah sorry! I see now that Wiola's code is correct but the error message says different thing than the code. Indeed, @vkucera could you check please?

[vkucera]

Hi @wrzesaCERN , your branch is missing some changes made in #12820 . Please rebase your branch and update the PR.

[wrzesaCERN]

Hi, could you please let me know if now is fine for you? I tried to rebase it

I don’t see any issue with “femto-dream-triplet-task-track-track-v0-pb-pb” in the CMakeLists, but I also have not seen that before in the output of that linear check. So maybe I’m simply not looking in the right place.

[vkucera]

Thanks, femto-dream-triplet-task-track-track-v0-pb-pb is correct.

[alibuild]

Error while checking build/O2Physics/o2 for 08c16f0 at 2025-09-11 21:28:

No log files found

Full log here.

[ktf]

Please push a new commit if you think this should be retested. I cannot retrigger tests right now.