[PWGJE] Fix: make doRhoAreaSub take jet by const reference #11618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaliva
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 27 errors, |
Collaborator
|
Thanks @alcaliva ! |
vkucera
changed the title
Collaborator
|
Just for my education, since these are already passed as reference with "&" why would they be copied? I thought "const" only made sure they were not modified |
Collaborator
Author
|
Hi @nzardosh, It is the o2-linter who complains when one loops over jets using non-const reference. I think it is just "good practise" because if the function does not need to modify jet, passing it as a non-const reference might be dangerous, as one might unintentionally alter the original object. |
Collaborator
|
@nzardosh It's not about a copy, it's about the |
nzardosh
approved these changes
Jun 17, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 18, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 20, 2025
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Jul 16, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vkucera