Skip to content

Conversation

@alcaliva
Copy link
Collaborator

@vkucera, I fixed the issue you mentioned in the previous PR here

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

O2 linter results: ❌ 27 errors, ⚠️ 0 warnings, 🔕 0 disabled

@vkucera
Copy link
Collaborator

vkucera commented Jun 13, 2025

Thanks @alcaliva

romainschotter
romainschotter previously approved these changes Jun 13, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 649659d at 2025-06-13 22:51:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/11600-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessInJets.cxx:1117:67: error: binding reference of type 'fastjet::PseudoJet&' to 'const fastjet::PseudoJet' discards qualifiers
/sw/SOURCES/O2Physics/11600-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessInJets.cxx:2105:69: error: binding reference of type 'fastjet::PseudoJet&' to 'const fastjet::PseudoJet' discards qualifiers
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Collaborator

vkucera commented Jun 13, 2025

Error while checking build/O2Physics/o2 for 649659d at 2025-06-13 22:51:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/11600-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessInJets.cxx:1117:67: error: binding reference of type 'fastjet::PseudoJet&' to 'const fastjet::PseudoJet' discards qualifiers
/sw/SOURCES/O2Physics/11600-slc9_x86-64/0/PWGLF/Tasks/Strangeness/strangenessInJets.cxx:2105:69: error: binding reference of type 'fastjet::PseudoJet&' to 'const fastjet::PseudoJet' discards qualifiers
ninja: build stopped: subcommand failed.

Full log here.

@hahassan7 This seems like a bug in doRhoAreaSub to me. It should not need to take jet by non-const reference.

@alcaliva
Copy link
Collaborator Author

Hi @vkucera,

I agree, because that function cannot (and does not) modify the jet, so it should not take a non-const ref.
In the meanwhile, I would close this PR as the existing code works.
Alberto

@github-actions github-actions bot added pwgje and removed pwglf labels Jun 14, 2025
@alcaliva alcaliva closed this Jun 14, 2025
auto-merge was automatically disabled June 14, 2025 06:24

Pull request was closed

@vkucera
Copy link
Collaborator

vkucera commented Jun 14, 2025

Hi @vkucera,

I agree, because that function cannot (and does not) modify the jet, so it should not take a non-const ref. In the meanwhile, I would close this PR as the existing code works. Alberto

It could have stayed opened as a draft until #11618 is merged.

@alcaliva
Copy link
Collaborator Author

I decided to close it because the new PR was "hiding" behind this one and I wanted it to be more visible.
I will fix it once the other PR (#11618) is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants