Skip to content

Conversation

@lubynets
Copy link
Contributor

@lubynets lubynets commented Jun 13, 2025

  1. The main() function is added as an entry point to enable compilation as CMake project.
  2. Added missing header.

[Update]
3. Added CMakeLists_HFInvMassFitter.txt and HFInvMassFitterLinkDef.h for fitter compilation as a standalone project.
4. Added Readme with instructions how to compile and run the fitter.

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title runMassFitter: add main() function and missing header [PWGHF] runMassFitter: add main() function and missing header Jun 13, 2025
@vkucera
Copy link
Collaborator

vkucera commented Jun 13, 2025

Hi @lubynets , what exactly are you trying to do?
ROOT macros have the .C extension, their entry point is a function with the same name as the file and they are supposed to be executed in the ROOT interpreter.
You just added a main function but the rest remains unchanged.

@lubynets
Copy link
Contributor Author

Hi @lubynets , what exactly are you trying to do? ROOT macros have the .C extension, their entry point is a function with the same name as the file and they are supposed to be executed in the ROOT interpreter. You just added a main function but the rest remains unchanged.

Hi @vkucera,
My purpose was to enable (in addition to ROOT interpreter) compiling the runMassFitter.C together with HFInvMassFitter.cxx/h as usual c++ code in CMake project or just from terminal using g++ command. This is how I use the fitter locally and I submitted the PR in order to (1) synchronize my copy of fitter with O2Physics and (2) share this version of compilation with others if somebody finds it useful.

@vkucera
Copy link
Collaborator

vkucera commented Jun 16, 2025

@lubynets OK. I think the use of the fitter should be documented somewhere. Do we not have an existing document for this?

@lubynets
Copy link
Contributor Author

@lubynets OK. I think the use of the fitter should be documented somewhere. Do we not have an existing document for this?

Hi @vkucera,
As far as I know there is no such a document. I'll create one and add as a README file in the same folder (it can be further extended with instructions for other macros), ok?
I could also share the CMakeLists.txt for the fitter, but is it acceptable from the point of O2Physics structure? (since the fitter is not a part of common compilation).

@vkucera
Copy link
Collaborator

vkucera commented Jun 16, 2025

@lubynets OK. I think the use of the fitter should be documented somewhere. Do we not have an existing document for this?

Hi @vkucera, As far as I know there is no such a document. I'll create one and add as a README file in the same folder (it can be further extended with instructions for other macros), ok? I could also share the CMakeLists.txt for the fitter, but is it acceptable from the point of O2Physics structure? (since the fitter is not a part of common compilation).

That would be very useful indeed. If the CMakeLists.txt is short, you can include its content in the README file. Otherwise you can just commit the file itself and put a comment inside to make it clear that it is not supposed to be a part of O2Physics compilation. You can also add a suffix to the name (e.g. CMakeLists_runMassFitter.txt) to make it more obvious.

@vkucera vkucera marked this pull request as draft June 17, 2025 08:49
@vkucera vkucera marked this pull request as draft June 17, 2025 08:49
@lubynets lubynets changed the title [PWGHF] runMassFitter: add main() function and missing header [PWGHF] runMassFitter: add main() function and missing header, provide Readme Jun 20, 2025
@lubynets lubynets marked this pull request as ready for review June 20, 2025 11:28
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lubynets , looks good to me.
Just please fix the minor typo.

@lubynets
Copy link
Contributor Author

Thanks @lubynets , looks good to me. Just please fix the minor typo.

Done

@vkucera vkucera enabled auto-merge (squash) June 26, 2025 20:14
@vkucera vkucera merged commit 7ba8397 into AliceO2Group:master Jun 27, 2025
12 of 14 checks passed
@lubynets lubynets deleted the HFFitter branch June 27, 2025 10:28
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
…e Readme (AliceO2Group#11611)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
…e Readme (AliceO2Group#11611)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
…e Readme (AliceO2Group#11611)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
…e Readme (AliceO2Group#11611)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
…e Readme (AliceO2Group#11611)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants