[Tools] Include What You Use #11552
Merged
[Tools] Include What You Use #11552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 36 errors, |
vkucera
requested review from
a team,
alibuild,
ddobrigk,
fcatalan92,
fmazzasc,
iarsene,
jgrosseo and
ktf
as code owners
ktf
reviewed
Jun 11, 2025
Tools/ML/model.h
Outdated
| #define TOOLS_ML_MODEL_H_ | ||
|
|
||
| // C++ and system includes | ||
| #include <onnxruntime_c_api.h> |
Collaborator
Author
There was a problem hiding this comment.
It provides OrtAllocatorType and OrtMemType.
Collaborator
Author
There was a problem hiding this comment.
In the else branch?
Collaborator
Author
There was a problem hiding this comment.
In both cases onnxruntime_c_api is included so I removed it.
ktf
reviewed
Jun 11, 2025
Tools/ML/model.cxx
Outdated
| // ONNX includes | ||
| #include "Tools/ML/model.h" | ||
|
|
||
| #include <onnxruntime_c_api.h> |
Member
There was a problem hiding this comment.
Also this one, I guess. It should be inside the ifdef.
Collaborator
Author
There was a problem hiding this comment.
It provides GraphOptimizationLevel, ORT_LOGGING_LEVEL_WARNING.
ktf
reviewed
Jun 11, 2025
Tools/ML/model.h
Outdated
|
|
||
| // ROOT includes | ||
| #include "TSystem.h" | ||
| #include <fairlogger/Logger.h> |
Member
There was a problem hiding this comment.
This one should be fixed in Framework/Logger.h
Collaborator
Author
There was a problem hiding this comment.
OK, I'll wait for the PR.
ddobrigk
approved these changes
Jun 24, 2025
fmazzasc
approved these changes
Jun 24, 2025
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Jul 16, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jul 18, 2025
JimunLee
pushed a commit
to JimunLee/O2Physics
that referenced
this pull request
Jul 22, 2025
vojmach
pushed a commit
to vojmach/O2Physics
that referenced
this pull request
Jul 23, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.