Skip to content

[PWGHF] Include What You Use #11549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkucera merged 1 commit into from
Jun 28, 2025
Merged

[PWGHF] Include What You Use #11549

vkucera merged 1 commit into from
Jun 28, 2025

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Jun 11, 2025 •
edited
Loading

@github-actions github-actions bot changed the title Include What You Use [PWGHF] Include What You Use Jun 11, 2025
@github-actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

O2 linter results: ❌ 401 errors, ⚠️ 0 warnings, 🔕 56 disabled

@alibuild alibuild mentioned this pull request Jun 11, 2025
Merged
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Jun 11, 2025
@alibuild
Please consider the following formatting changes to AliceO2Group#11549 (
7be3ea1 
#124)
@alibuild alibuild mentioned this pull request Jun 11, 2025
Merged
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Jun 11, 2025
@alibuild
Please consider the following formatting changes to AliceO2Group#11549 (
3b51821 
#126)
@vkucera vkucera mentioned this pull request Jun 11, 2025
Open
@alibuild alibuild mentioned this pull request Jun 11, 2025
Merged
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Jun 11, 2025
@alibuild
Please consider the following formatting changes to AliceO2Group#11549 (
2267e74 
#127)
@alibuild alibuild mentioned this pull request Jun 11, 2025
Merged
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Jun 11, 2025
@alibuild
Please consider the following formatting changes to AliceO2Group#11549 (
4d7a27b 
#128)
@vkucera vkucera force-pushed the iwyu-PWGHF branch 2 times, most recently from 61b7ea5 to bb230e5 Compare June 12, 2025 18:25
@alibuild alibuild mentioned this pull request Jun 12, 2025
Merged
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Jun 12, 2025
@alibuild
Please consider the following formatting changes to AliceO2Group#11549 (
1be2bcc 
#129)
@vkucera vkucera marked this pull request as ready for review June 12, 2025 18:51
@vkucera vkucera marked this pull request as draft June 12, 2025 18:52
@vkucera vkucera marked this pull request as ready for review June 12, 2025 19:15
@alibuild
Copy link
Collaborator

alibuild commented Jun 13, 2025

Error while checking build/O2Physics/o2 for cab923a at 2025-06-13 13:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:59:42: error: 'TrackParametrizationWithError' in namespace 'o2::track' does not name a template type
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:59:71: error: expected ',' or '...' before '<' token
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:67:3: error: 'trackparCov' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:79:22: error: 'trackSign' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:80:19: error: 'tpcNClsFound' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:81:35: error: 'tpcChi2NCl' was not declared in this scope; did you mean 'o2::aod::track::tpcChi2NCl'?
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:92:14: error: 'TrackParametrizationWithError' is not a member of 'o2::track'
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:93:3: error: 'trackparCov' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:102:57: error: 'TrackParametrizationWithError' in namespace 'o2::track' does not name a template type
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:102:86: error: expected ',' or '...' before '<' token
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:107:38: error: 'trackparCov' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:107:51: error: 'trackSign' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:107:62: error: 'tpcNClsFound' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:107:76: error: 'tpcChi2NCl' was not declared in this scope; did you mean 'o2::aod::track::tpcChi2NCl'?
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:118:61: error: 'TrackParametrizationWithError' in namespace 'o2::track' does not name a template type
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:118:90: error: expected ',' or '...' before '<' token
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:122:3: error: 'trackparCov' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:142:41: error: 'charge' was not declared in this scope; did you mean 'char'?
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:142:49: error: 'mass' was not declared in this scope
/sw/SOURCES/O2Physics/11549-slc9_x86-64/0/Tools/KFparticle/KFUtilities.h:157:12: error: 'TrackParCov' in namespace 'o2::track' does not name a type
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft June 13, 2025 12:30
@alibuild alibuild mentioned this pull request Jun 26, 2025
Merged
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Jun 26, 2025
@alibuild
Please consider the following formatting changes to AliceO2Group#11549 (
9676a16 
#132)
@vkucera vkucera force-pushed the iwyu-PWGHF branch 2 times, most recently from 7426034 to 9c6d437 Compare June 27, 2025 12:31
@vkucera vkucera marked this pull request as ready for review June 27, 2025 12:41
@vkucera vkucera enabled auto-merge (squash) June 27, 2025 13:15
alibuild
alibuild previously approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

This was referenced Jun 27, 2025
Merged
Merged
@vkucera vkucera disabled auto-merge June 27, 2025 21:47
@vkucera vkucera enabled auto-merge (squash) June 27, 2025 21:47
alibuild
alibuild approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

@vkucera vkucera merged commit 3d73704 into AliceO2Group:master Jun 28, 2025
12 of 13 checks passed
@vkucera vkucera deleted the iwyu-PWGHF branch June 28, 2025 14:53
jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025
@vkucera @jpxrk
[PWGHF] Include What You Use (AliceO2Group#11549)
5000c61
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025
@vkucera
[PWGHF] Include What You Use (AliceO2Group#11549)
8d6586e
JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025
@vkucera
[PWGHF] Include What You Use (AliceO2Group#11549)
30498f2
vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025
@vkucera @vojmach
[PWGHF] Include What You Use (AliceO2Group#11549)
a209b3f
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@vkucera @jloemker
[PWGHF] Include What You Use (AliceO2Group#11549)
f763ae0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vkucera @alibuild