-
Notifications
You must be signed in to change notification settings - Fork 615
[PWGLF] Fix bug in to-build cascade list mapping #11031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 128 errors, |
|
The compilation error seems unrelated :-( |
|
Hello @ddobrigk, any kind of Join would produce an error about different size, there is no other code path, so there may be something else at play here. Do you |
Hi @aalkin, I'm afraid in this case, the error is not reported properly - that's what I mean. I'll contact you privately with the log and the test I did to illustrate that the tables are, in fact, not joinable. About |
|
Thanks @ddobrigk for the fix! |
@fcatalan92 this fixes the bug that manifested itself in the omegaC when building in the KF path.
The issue is that in a recent commit I introduced a check for TPC-only V0s being used in cascades in the first entry point of the builder and removed those cascades from the pool, which accidentally renders the joinability between
Cascadesand theCascades-to-[]Data interlinks false because a tiny amount of candidates is rejected and the interlink tables are smaller. This is inadequately reported by the framework for some reason in the particular use case of the OmegaC building, since there was a segmentation fault instead of a message of "table size mismatch" (tagging also @aalkin - I suspect it may be because we are dealing with linked derived data here, not sure). I found out the table size mismatch by isolating the joined table combination that led to the crash manually.In the fix, I simply don't filter out cascades that use tpc-only V0s; these are filtered from actual candidate generation anyhow a posteriori via a build call that includes the protection added by #10908, but by not removing the cascades from the build pool, the interlinks will have the same size as the original
Cascadestable.Tagging also @romainschotter @gianniliveraro; further tagging @f3sch - we should still find out why cascades seem to be using TPC-only V0s as this should not happen in the svertexer from what I remember.