Skip to content

Conversation

@ddobrigk
Copy link
Collaborator

@ddobrigk ddobrigk commented Apr 29, 2025

@fcatalan92 this fixes the bug that manifested itself in the omegaC when building in the KF path.

The issue is that in a recent commit I introduced a check for TPC-only V0s being used in cascades in the first entry point of the builder and removed those cascades from the pool, which accidentally renders the joinability between Cascades and the Cascades-to-[]Data interlinks false because a tiny amount of candidates is rejected and the interlink tables are smaller. This is inadequately reported by the framework for some reason in the particular use case of the OmegaC building, since there was a segmentation fault instead of a message of "table size mismatch" (tagging also @aalkin - I suspect it may be because we are dealing with linked derived data here, not sure). I found out the table size mismatch by isolating the joined table combination that led to the crash manually.

In the fix, I simply don't filter out cascades that use tpc-only V0s; these are filtered from actual candidate generation anyhow a posteriori via a build call that includes the protection added by #10908, but by not removing the cascades from the build pool, the interlinks will have the same size as the original Cascades table.

Tagging also @romainschotter @gianniliveraro; further tagging @f3sch - we should still find out why cascades seem to be using TPC-only V0s as this should not happen in the svertexer from what I remember.

@github-actions
Copy link

github-actions bot commented Apr 29, 2025

O2 linter results: ❌ 128 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ddobrigk
Copy link
Collaborator Author

The compilation error seems unrelated :-(

@aalkin
Copy link
Member

aalkin commented Apr 30, 2025

Hello @ddobrigk, any kind of Join would produce an error about different size, there is no other code path, so there may be something else at play here. Do you reserve() the size of the produced tables anywhere?

@ddobrigk
Copy link
Collaborator Author

Hello @ddobrigk, any kind of Join would produce an error about different size, there is no other code path, so there may be something else at play here. Do you reserve() the size of the produced tables anywhere?

Hi @aalkin, I'm afraid in this case, the error is not reported properly - that's what I mean. I'll contact you privately with the log and the test I did to illustrate that the tables are, in fact, not joinable. About reserve(), I did not call it but it's irrelevant in the code path because the bug of different sizes would still be there if reserve() was called...

@fcatalan92
Copy link
Collaborator

Thanks @ddobrigk for the fix!

@mtorresc15

@njacazio njacazio merged commit c84064b into AliceO2Group:master Apr 30, 2025
10 of 13 checks passed
mfaggin pushed a commit to mfaggin/O2Physics that referenced this pull request Apr 30, 2025
@ddobrigk ddobrigk deleted the bugfixbuilder branch May 1, 2025 09:31
bghanley1995 pushed a commit to bghanley1995/O2Physics that referenced this pull request May 5, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
ddobrigk added a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants