[PWGLF] Protect against accidental acceptance of TPC-only V0s #10908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddobrigk
requested review from
ChiaraDeMartin95,
alibuild,
ercolessi,
njacazio and
skundu692
as code owners
njacazio
approved these changes
Apr 18, 2025
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
May 17, 2025
…2Group#10908) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
…2Group#10908) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
…2Group#10908) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
…2Group#10908) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to reject TPC-only tracks from V0 building via the strangeness builder helper. Controlled by the last
buildV0candidateparameter, with default behaviour being reject.Crucially, this rejects 80-90% of
aod::V0sin high-IR pp because of the way we store V0s with at least one TPC-only track: we duplicate V0s many times (up to 20x) in different collisions, and having this overlooked when doing traditional (K0/Lambda) building could introduce unwanted CPU usage and, in the worst case, spurious background in large quantity.Tagging also @mpuccio as this will directly impact current trigger code as well even if the change is not in the EventFiltering directory. Hope this helps and happy easter!