Skip to content

Force TPC common mode correction #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Jul 3, 2025
Merged

Force TPC common mode correction #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions MC/bin/o2dpg_sim_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,6 +994,9 @@ def putConfigValues(listOfMainKeys=[], localCF = {}):

tpcLocalCF={"DigiParams.maxOrbitsToDigitize" : str(orbitsPerTF), "DigiParams.seed" : str(TFSEED)}

# force TPC common mode correction in all cases to avoid issues the CMk values stored in the CCDB
tpcLocalCF['TPCEleParam.DigiMode'] = str(2) # 2 = o2::tpc::DigitzationMode::ZeroSuppressionCMCorr from TPCBase/ParameterElectronics.h
Copy link
Contributor

@sawenzel sawenzel Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we just force this all the time, not just for some runs that are buggy?

Copy link
Collaborator Author

@wiechula wiechula Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, for all other runs this is done by the default auto mode anyhow ...

Copy link
Collaborator Author

@wiechula wiechula Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the best would be to fix the buggy CCDB objects, but this will be quite some work and the benefit will be minimal, since anyhow the common mode in pp 500kHz is very small. So the effect on the data which was not corrected in the electronics should be negligible.

Copy link
Contributor

@sawenzel sawenzel Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, for all other runs this is done by the default auto mode anyhow ...

I have a doubt about this. If we set the parameter here, do you think that other (good) runs will overwrite or ignore this parameter here? (I think that manually set things will have the highest priority).

Copy link
Collaborator Author

@wiechula wiechula Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to my understanding manually set values should have the highest priority. So this should (hopefully) overwrite everything that comes from the CCDB. The CM was enabled mid of 2023, so all runs after this will automatically switch to DigiMode=2. Now we force this to be done also for run before that date. This was anyhow also the default in older MC productions, before we changed to auto mode.

Copy link
Contributor

@sawenzel sawenzel Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did someone test that it actually works and fixes our problems? Then I can merge.


# handle distortions and scaling using MC maps
# this assumes the lumi inside the maps is stored in FT0 (pp) scalers
# in case of PbPb the conversion factor ZDC ->FT0 (pp) must be taken into account in the scalers
Expand Down