Force TPC common mode correction #2045
Conversation
This is done to avoid issues the CMk values stored in the CCDB. Data before 30/06/2023, 16:41:42 (first good run should be 539008 LHZ23ze) are affected
wiechula
requested review from
chiarazampolli,
jackal1-66 and
sawenzel
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| tpcLocalCF={"DigiParams.maxOrbitsToDigitize" : str(orbitsPerTF), "DigiParams.seed" : str(TFSEED)} | ||
|
|
||
| # force TPC common mode correction in all cases to avoid issues the CMk values stored in the CCDB | ||
| tpcLocalCF['TPCEleParam.DigiMode'] = str(2) # 2 = o2::tpc::DigitzationMode::ZeroSuppressionCMCorr from TPCBase/ParameterElectronics.h |
There was a problem hiding this comment.
so we just force this all the time, not just for some runs that are buggy?
There was a problem hiding this comment.
Well, for all other runs this is done by the default auto mode anyhow ...
There was a problem hiding this comment.
Actually, the best would be to fix the buggy CCDB objects, but this will be quite some work and the benefit will be minimal, since anyhow the common mode in pp 500kHz is very small. So the effect on the data which was not corrected in the electronics should be negligible.
There was a problem hiding this comment.
Well, for all other runs this is done by the default auto mode anyhow ...
I have a doubt about this. If we set the parameter here, do you think that other (good) runs will overwrite or ignore this parameter here? (I think that manually set things will have the highest priority).
There was a problem hiding this comment.
Also to my understanding manually set values should have the highest priority. So this should (hopefully) overwrite everything that comes from the CCDB. The CM was enabled mid of 2023, so all runs after this will automatically switch to DigiMode=2. Now we force this to be done also for run before that date. This was anyhow also the default in older MC productions, before we changed to auto mode.
There was a problem hiding this comment.
Did someone test that it actually works and fixes our problems? Then I can merge.
|
Hi @sawenzel, |
3 participants
This is done to avoid issues the CMk values stored in the CCDB. Data before 30/06/2023, 16:41:42 (first good run should be 539008 LHZ23ze) are affected