Skip to content

Fix ClusterDecoderRawSpec to work with std::pmr #14386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Jun 10, 2025
Merged

Fix ClusterDecoderRawSpec to work with std::pmr #14386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 11 additions & 19 deletions Detectors/TPC/workflow/src/ClusterDecoderRawSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ namespace o2
{
namespace tpc
{

/// create the processor spec for TPC raw cluster decoder converting TPC raw to native clusters
/// Input: raw pages of TPC raw clusters
/// Output: vector of containers with clusters in ClusterNative format, one container per
Expand Down Expand Up @@ -79,27 +80,18 @@ DataProcessorSpec getClusterDecoderRawSpec(bool sendMC)
// init the stacks for forwarding the sector header
// FIXME check if there is functionality in the DPL to forward the stack
// FIXME make one function
o2::header::Stack rawHeaderStack;
o2::header::Stack mcHeaderStack;
o2::tpc::TPCSectorHeader const* sectorHeaderMC = nullptr;
if (DataRefUtils::isValid(mclabelref)) {
sectorHeaderMC = DataRefUtils::getHeader<o2::tpc::TPCSectorHeader*>(mclabelref);
if (sectorHeaderMC) {
o2::header::Stack actual{*sectorHeaderMC};
std::swap(mcHeaderStack, actual);
if (sectorHeaderMC->sector() < 0) {
pc.outputs().snapshot(Output{gDataOriginTPC, DataDescription("CLNATIVEMCLBL"), fanSpec, std::move(mcHeaderStack)}, fanSpec);
}
}
}

if (sectorHeaderMC && sectorHeaderMC->sector() < 0) {
pc.outputs().snapshot(Output{gDataOriginTPC, DataDescription("CLNATIVEMCLBL"), fanSpec, {*sectorHeaderMC}}, fanSpec);
}
auto const* sectorHeader = DataRefUtils::getHeader<o2::tpc::TPCSectorHeader*>(ref);
if (sectorHeader) {
o2::header::Stack actual{*sectorHeader};
std::swap(rawHeaderStack, actual);
if (sectorHeader->sector() < 0) {
pc.outputs().snapshot(Output{gDataOriginTPC, DataDescription("CLUSTERNATIVE"), fanSpec, std::move(rawHeaderStack)}, fanSpec);
return;
}
if (sectorHeader && sectorHeader->sector() < 0) {
pc.outputs().snapshot(Output{gDataOriginTPC, DataDescription("CLUSTERNATIVE"), fanSpec, {*sectorHeader}}, fanSpec);
return;
}
assert(sectorHeaderMC == nullptr || sectorHeader->sector() == sectorHeaderMC->sector());

Expand Down Expand Up @@ -166,8 +158,8 @@ DataProcessorSpec getClusterDecoderRawSpec(bool sendMC)
// output of the decoder is sorted in (sector,globalPadRow) coordinates, individual
// containers are created for clusters and MC labels per (sector,globalPadRow) address
char* outputBuffer = nullptr;
auto outputAllocator = [&pc, &fanSpec, &outputBuffer, &rawHeaderStack](size_t size) -> char* {
outputBuffer = pc.outputs().newChunk(Output{gDataOriginTPC, DataDescription("CLUSTERNATIVE"), fanSpec, std::move(rawHeaderStack)}, size).data();
auto outputAllocator = [&pc, &fanSpec, &outputBuffer, sectorHeader](size_t size) -> char* {
outputBuffer = pc.outputs().newChunk(Output{gDataOriginTPC, DataDescription("CLUSTERNATIVE"), fanSpec, sectorHeader ? o2::header::Stack{*sectorHeader} : o2::header::Stack{}}, size).data();
return outputBuffer;
};
MCLabelContainer mcout;
Expand All @@ -188,7 +180,7 @@ DataProcessorSpec getClusterDecoderRawSpec(bool sendMC)
// serialize the complete list of MC label containers
ConstMCLabelContainer labelsFlat;
mcout.flatten_to(labelsFlat);
pc.outputs().snapshot(Output{gDataOriginTPC, DataDescription("CLNATIVEMCLBL"), fanSpec, std::move(mcHeaderStack)}, labelsFlat);
pc.outputs().snapshot(Output{gDataOriginTPC, DataDescription("CLNATIVEMCLBL"), fanSpec, sectorHeaderMC ? o2::header::Stack{*sectorHeaderMC} : o2::header::Stack{}}, labelsFlat);
}
};

Expand Down