Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jun 10, 2025

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Member Author

ktf commented Jun 10, 2025

@davidrohr @shahor02 @wiechula could you have a look, please? I think the logic is respected, however I am not sure if we have coverage for it in the full system test.

@davidrohr
Copy link
Collaborator

@davidrohr @shahor02 @wiechula could you have a look, please? I think the logic is respected, however I am not sure if we have coverage for it in the full system test.

I think actually this class is not even used any more. It was written by Matthias for the original TPC clusters supposed to come from the FPGA. Anyhow, looking at it briefly what you did seems correct. But I didn't test it, and also no idea how I should easily test it.

@ktf
Copy link
Member Author

ktf commented Jun 10, 2025

In that case, I am happy to debug the change, if needed. Merging since all tests are green.

@ktf ktf merged commit 73b2592 into AliceO2Group:dev Jun 10, 2025
17 checks passed
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants