Skip to content

TPC: Fix digitizer workflow to load GEM params from CCDB before creating Polya file #14267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
May 13, 2025
Merged

TPC: Fix digitizer workflow to load GEM params from CCDB before creating Polya file #14267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Steer/DigitizerWorkflow/src/SimpleDigitizerWorkflow.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ int getNumTPCLanes(std::vector<int> const& sectors, ConfigContext const& configc

// ------------------------------------------------------------------

void initTPC()
void initTPC(long timestamp)
{
// We only want to do this for the DPL master
// I am not aware of an easy way to query if "I am DPL master" so
Expand All @@ -308,6 +308,12 @@ void initTPC()

auto& cdb = o2::tpc::CDBInterface::instance();
cdb.setUseDefaults();

// IMPORTANT: load ParameterGEM from CCDB
auto& ccdbManager = o2::ccdb::BasicCCDBManager::instance();
ccdbManager.getSpecific<o2::tpc::ParameterGEM>(o2::tpc::CDBTypeMap.at(o2::tpc::CDBType::ParGEM), timestamp);
Copy link
Collaborator

@sawenzel sawenzel May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after a quick code inspection, it appears that GEMAmplification not only relies on ParameterGEM but also in GainMap and ParameterGas. Shouldn't these values then also be fetched from CCDB prior to creating GEMAmplification? @wiechula @tubagundem

LOGP(info, "initTPC: TPC GEM param updated for time {}", timestamp);
o2::tpc::ParameterGEM::Instance().printKeyValues(true, true);
// by invoking this constructor we make sure that a common file will be created
// in future we should take this from OCDB and just forward per message
const static auto& ampl = o2::tpc::GEMAmplification::instance();
Expand Down Expand Up @@ -592,7 +598,7 @@ WorkflowSpec defineDataProcessing(ConfigContext const& configcontext)

if (isEnabled(o2::detectors::DetID::TPC)) {
if (!helpasked && ismaster) {
initTPC();
initTPC(hbfu.startTime);
}

tpcsectors = o2::RangeTokenizer::tokenize<int>(configcontext.options().get<std::string>("tpc-sectors"));
Expand Down