Skip to content

Conversation

@tubagundem
Copy link
Contributor

@tubagundem tubagundem commented May 13, 2025

The initTPC() function is updated to load GEM parameters from the CCDB using the provided timestamp. This ensures that the Polya file is generated with the correct amplification function with the tuning gain value from the CCDB. Previously, the Polya file was created using default GEM parameters, which led to inconsistencies in anchored MC.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sawenzel sawenzel added the bug label May 13, 2025
@sawenzel sawenzel merged commit 4b72f18 into AliceO2Group:dev May 13, 2025
13 of 14 checks passed

// IMPORTANT: load ParameterGEM from CCDB
auto& ccdbManager = o2::ccdb::BasicCCDBManager::instance();
ccdbManager.getSpecific<o2::tpc::ParameterGEM>(o2::tpc::CDBTypeMap.at(o2::tpc::CDBType::ParGEM), timestamp);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after a quick code inspection, it appears that GEMAmplification not only relies on ParameterGEM but also in GainMap and ParameterGas. Shouldn't these values then also be fetched from CCDB prior to creating GEMAmplification? @wiechula @tubagundem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants