-
Notifications
You must be signed in to change notification settings - Fork 483
DataSampling: make sure the original DataHeader is available in the sampled data #14164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
@shahor02 this is what we discussed. The only remaining bit should be to use: where you (possibly) iterated over the sampled data. Notice that it will always use the Finally if you do not specify any template argument to @knopers8 @Barthelemy this will copy the original headers into the DataSamplingHeader unconditionally. Let me know if this needs further discussion. |
knopers8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
|
This works for @shahor02 usecase. I will merge once the tests pass. |
|
Error while checking build/O2/fullCI_slc9 for 2ac46e8 at 2025-04-10 15:28: Full log here. |
Stack created with Sapling. Best reviewed with ReviewStack.