Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Apr 9, 2025

@ktf ktf requested a review from a team as a code owner April 9, 2025 14:17
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Member Author

ktf commented Apr 9, 2025

@knopers8 @shahor02 This will make sure we do not need to move the DataSamplingHeader in the framework. We just need to similarly patch InputRecordWalker and use it as InputRecordWalker<DataSamplingHeader, DataHeader> where it is used.

@alibuild
Copy link
Collaborator

alibuild commented Apr 9, 2025

Error while checking build/O2/fullCI_slc9 for cc6abbe at 2025-04-09 21:43:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
command alien-token-init had nonzero exit code 2


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/fc85f8a413fbc54eff13c19de3df072aab76f549/slc9_x86-64/o2checkcode/1.0-local126/etc/modulefiles
++ cat
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for dde5875 at 2025-04-10 09:32:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14160-slc9_x86-64/0/Framework/Utils/include/DPLUtils/DPLRawPageSequencer.h:194:3: error: invalid use of template-name 'o2::framework::InputRecordWalker' without an argument list
/sw/SOURCES/O2/14160-slc9_x86-64/0/Framework/Utils/include/DPLUtils/DPLRawPageSequencer.h:120:21: error: 'payload' was not declared in this scope; did you mean 'setpayload'?
/sw/SOURCES/O2/14160-slc9_x86-64/0/Framework/Utils/include/DPLUtils/DPLRawPageSequencer.h:123:18: error: 'payload' was not declared in this scope; did you mean 'setpayload'?
/sw/SOURCES/O2/14160-slc9_x86-64/0/Framework/Utils/include/DPLUtils/DPLRawPageSequencer.h:194:3: error: invalid use of template-name 'o2::framework::InputRecordWalker' without an argument list
/sw/SOURCES/O2/14160-slc9_x86-64/0/Framework/Utils/include/DPLUtils/DPLRawPageSequencer.h:120:21: error: 'payload' was not declared in this scope; did you mean 'setpayload'?
/sw/SOURCES/O2/14160-slc9_x86-64/0/Framework/Utils/include/DPLUtils/DPLRawPageSequencer.h:123:18: error: 'payload' was not declared in this scope; did you mean 'setpayload'?
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 11a8141 at 2025-04-10 13:57:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/5923e3a36b22ba26837dffa0422b2f347c8c34fb/slc9_x86-64/o2checkcode/1.0-local120/etc/modulefiles
++ cat
--

Full log here.

@ktf ktf merged commit 0a831b2 into AliceO2Group:dev Apr 10, 2025
9 of 11 checks passed
@ktf
Copy link
Member Author

ktf commented Apr 10, 2025

Tested with @shahor02 usecase. Works. I will merge #14164 once all the other tests (including in particular QC) pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants