Skip to content

GPU: Fix GPUChkErr macro, GPU::Common should not use GPU::GPUTracking internals #14082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
Mar 18, 2025
Merged

GPU: Fix GPUChkErr macro, GPU::Common should not use GPU::GPUTracking internals #14082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion GPU/Common/GPUCommonHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#define GPUChkErrSI(x) o2::gpu::internal::GPUReconstructionChkErr(x, __FILE__, __LINE__, false)

#include "GPUCommonDef.h"
#include "GPUCommonLogger.h"
#include <cstdint>

namespace o2::gpu::internal
Expand All @@ -43,7 +44,7 @@ extern int32_t GPUCOMMON_INTERNAL_CAT(GPUReconstruction, GPUCA_GPUTYPE, ChkErr)(
inline int32_t GPUReconstructionCPUChkErr(const int64_t error, const char* file, int32_t line)
{
if (error) {
GPUError("GPUCommon Error Code %d (%s:%d)", error, file, line);
LOGF(error, "GPUCommon Error Code %ld (%s:%d)", (long)error, file, line);
}
return error != 0;
}
Expand Down