Skip to content

GLOQC: Add PV contrib vs ITS tracks #14035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
f3sch wants to merge 1 commit into from
Closed

GLOQC: Add PV contrib vs ITS tracks #14035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Detectors/GLOQC/include/GLOQC/MatchITSTPCQC.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class MatchITSTPCQC
bool processV0(int iv, o2::globaltracking::RecoContainer& recoData, std::vector<float>& mTBinClOcc, float pvTime);
bool refitV0(const o2::dataformats::V0Index& id, o2::dataformats::V0& v0, o2::globaltracking::RecoContainer& recoData);

// returning raw pointer but this task keeps ownership!
TH1D* getHistoPtNum(matchType m) const { return mPtNum[m]; }
TH1D* getHistoPtDen(matchType m) const { return mPtDen[m]; }
TEfficiency* getFractionITSTPCmatch(matchType m) const { return mFractionITSTPCmatch[m]; }
Expand Down Expand Up @@ -144,6 +145,9 @@ class MatchITSTPCQC
TH3F* getHistoK0MassVsPtVsOccpp() const { return mK0MassVsPtVsOccpp; }
TH3F* getHistoK0MassVsPtVsOccPbPb() const { return mK0MassVsPtVsOccPbPb; }

auto getHistoPVNContVsITSTracks() const { return mPVNContVsITSTracks; }
auto getHistoPVNContVsITSTracksPbPb() const { return mPVNContVsITSTracksPbPb; }

void getHistos(TObjArray& objar);

/// \brief Publishes the histograms to the publisher e.g. the one provided by the QC task
Expand Down Expand Up @@ -247,6 +251,9 @@ class MatchITSTPCQC
publisher->startPublishing(mK0MassVsPtVsOccpp);
publisher->startPublishing(mK0MassVsPtVsOccPbPb);
}

publisher->startPublishing(mPVNContVsITSTracks);
publisher->startPublishing(mPVNContVsITSTracksPbPb);
}

void setTrkSources(GID::mask_t src) { mSrc = src; }
Expand Down Expand Up @@ -315,6 +322,8 @@ class MatchITSTPCQC
gsl::span<const o2::its::TrackITS> mITSTracks;
// ITS-TPC
gsl::span<const o2::dataformats::TrackTPCITS> mITSTPCTracks;
// PVs
gsl::span<const o2::dataformats::PrimaryVertex> mPVs;
bool mUseMC = false; // Usage of the MC information
bool mUseTrkPID = false; // Usage of the PID hypothesis in tracking
float mBz = 0; ///< nominal Bz
Expand Down Expand Up @@ -457,7 +466,11 @@ class MatchITSTPCQC
float mK0MaxDCA = 0.01; // max DCA to select the K0
float mK0MinCosPA = 0.995; // min cosPA to select the K0

ClassDefNV(MatchITSTPCQC, 4);
// for Mutliplicty PV
TH2F* mPVNContVsITSTracks{nullptr};
TH2F* mPVNContVsITSTracksPbPb{nullptr};

ClassDefNV(MatchITSTPCQC, 5);
};
} // namespace gloqc
} // namespace o2
Expand Down
58 changes: 55 additions & 3 deletions Detectors/GLOQC/src/MatchITSTPCQC.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

#include "GLOQC/MatchITSTPCQC.h"
#include "ReconstructionDataFormats/TrackTPCITS.h"
#include "ReconstructionDataFormats/VtxTrackRef.h"
#include "DataFormatsTPC/TrackTPC.h"
#include "DetectorsBase/Propagator.h"
#include "SimulationDataFormat/MCUtils.h"
Expand Down Expand Up @@ -133,6 +134,10 @@ void MatchITSTPCQC::deleteHistograms()
// K0
delete mK0MassVsPtVsOccpp;
delete mK0MassVsPtVsOccPbPb;

// PV
delete mPVNContVsITSTracks;
delete mPVNContVsITSTracksPbPb;
}

//__________________________________________________________
Expand Down Expand Up @@ -220,6 +225,9 @@ void MatchITSTPCQC::reset()
mK0MassVsPtVsOccpp->Reset();
mK0MassVsPtVsOccPbPb->Reset();
}

mPVNContVsITSTracks->Reset();
mPVNContVsITSTracksPbPb->Reset();
}

//__________________________________________________________
Expand Down Expand Up @@ -440,6 +448,29 @@ bool MatchITSTPCQC::init()
mK0MassVsPtVsOccPbPb = new TH3F("mK0MassVsPtVsOccPbPb", "K0 invariant mass vs Pt vs TPC occupancy; Pt [GeV/c]; K0s mass [GeV/c^2]; TPC occ", nbinsPtK0, xbinsPtK0, nbinsMassK0, ybinsMassK0, nbinsMultK0PbPb, zbinsMultK0PbPb);
}

auto makeBins = [](int out) {
std::array<Double_t, 101> xbins{0};
Double_t xlogmin = TMath::Log10(1);
Double_t xlogmax = TMath::Log10(out);
Double_t dlogx = (xlogmax - xlogmin) / 100;
for (int i = 0; i <= 100; i++) {
Double_t xlog = xlogmin + (i * dlogx);
xbins[i] = TMath::Exp(TMath::Log(10) * xlog);
}
return xbins;
};

{
auto xbinsPV = makeBins(250);
auto xbinsITS = makeBins(2000);
mPVNContVsITSTracks = new TH2F("mPVNContVsITSTracks", "PV NCont. vs ITS Tracks;PV NCont.;ITS Tracks", 100, xbinsPV.data(), 100, xbinsITS.data());
}
{
auto xbinsPV = makeBins(10'000);
auto xbinsITS = makeBins(60'000);
mPVNContVsITSTracksPbPb = new TH2F("mPVNContVsITSTracksPbPb", "PV NCont. vs ITS Tracks;PV NCont.;ITS Tracks", 100, xbinsPV.data(), 100, xbinsITS.data());
}

LOG(info) << "Printing configuration cuts";
printParams();

Expand Down Expand Up @@ -516,10 +547,29 @@ void MatchITSTPCQC::run(o2::framework::ProcessingContext& ctx)
mTPCTracks = mRecoCont.getTPCTracks();
mITSTracks = mRecoCont.getITSTracks();
mITSTPCTracks = mRecoCont.getTPCITSTracks();
mPVs = mRecoCont.getPrimaryVertices();

LOG(info) << "****** Number of found ITSTPC tracks = " << mITSTPCTracks.size();
LOG(info) << "****** Number of found TPC tracks = " << mTPCTracks.size();
LOG(info) << "****** Number of found ITS tracks = " << mITSTracks.size();
LOG(info) << "****** Number of PVs = " << mPVs.size();

const auto& pvm = mRecoCont.getPrimaryVertexMatchedTrackRefs();
for (int i{0}; i < mPVs.size(); ++i) {
const auto& pv = mPVs[i];
const auto& m = pvm[i];
// count the number of ITS tracks that were associated to this PV
// then one can plot the number of tracks contributing to a PV against the available pool
// (+ ITS tracks only in OB which by constructing cannot contribute).
Double_t c{0.};
for (int src = GIndex::NSources; src--;) {
if (!GIndex::includesDet(DetID::ITS, src)) {
continue;
}
c += m.getEntriesOfSource(src);
}
((mIsHI) ? mPVNContVsITSTracksPbPb : mPVNContVsITSTracks)->Fill(pv.getNContributors(), c);
Comment on lines +557 to +571
Copy link
Collaborator Author

@f3sch f3sch Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahor02, does the accounting look correct to you?

Copy link
Collaborator Author

@f3sch f3sch Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @shahor02 :)

Copy link
Collaborator

@shahor02 shahor02 Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed the question...
If the aim is to show the evolution of the pool size vs ncontrib, it is fine, but they will be strongly correlated.
The limits of histos look bit strange: the number of ITS time-associated tracks should be only a few 10% higher than the contributors, not an order of magnitude.

Copy link
Collaborator Author

@f3sch f3sch Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, actually I should have not pinged you, sorry about that. Since I will not be available for the next three weeks, I will close this and afterward continue working on this :)

}

// cache selection for TPC and ITS tracks
std::vector<bool> isTPCTrackSelectedEntry(mTPCTracks.size(), false);
Expand Down Expand Up @@ -991,11 +1041,9 @@ void MatchITSTPCQC::run(o2::framework::ProcessingContext& ctx)
}
}

if (mDoK0QC && mRecoCont.getPrimaryVertices().size() > 0) {
if (mDoK0QC && mPVs.size() > 0) {
// now doing K0S
mFitterV0.setBz(mBz);
const auto pvertices = mRecoCont.getPrimaryVertices();
LOG(info) << "****** Number of PVs = " << pvertices.size();

// getting occupancy estimator
mNHBPerTF = o2::base::GRPGeomHelper::instance().getGRPECS()->getNHBFPerTF();
Expand Down Expand Up @@ -1421,6 +1469,10 @@ void MatchITSTPCQC::getHistos(TObjArray& objar)
// V0
objar.Add(mK0MassVsPtVsOccpp);
objar.Add(mK0MassVsPtVsOccPbPb);

// PV Multiplicity
objar.Add(mPVNContVsITSTracks);
objar.Add(mPVNContVsITSTracksPbPb);
}

void MatchITSTPCQC::printParams() const
Expand Down
1 change: 1 addition & 0 deletions Detectors/GlobalTrackingWorkflow/qc/src/ITSTPCMatchingQCSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ void ITSTPCMatchingQCDevice::init(InitContext& /*ic*/)
mMatchITSTPCQC = std::make_unique<o2::gloqc::MatchITSTPCQC>();
mMatchITSTPCQC->setDataRequest(mDataRequest);
mMatchITSTPCQC->setTrkSources(o2::dataformats::GlobalTrackID::getSourcesMask(mTrkSources));
mMatchITSTPCQC->setNBinsPt(params.nBinsPt);
mMatchITSTPCQC->setMinPtITSCut(params.minPtITSCut);
mMatchITSTPCQC->setEtaITSCut(params.etaITSCut);
mMatchITSTPCQC->setMinNClustersITS(params.minNITSClustersCut);
Expand Down