GLOQC: Add PV contrib vs ITS tracks #14035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
f3sch
force-pushed
the
dev
branch
3 times, most recently
from
c832b79 to
cada942
Compare
f3sch
requested review from
a team,
Barthelemy,
justonedev1,
knopers8 and
shahor02
as code owners
Collaborator
|
Error while checking build/O2/fullCI_slc9 for cada942 at 2025-03-19 14:08: Full log here. |
knopers8
reviewed
Mar 24, 2025
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 940ffc1 at 2025-04-09 13:34: Full log here. |
f3sch
commented
Mar 29, 2025
Comment on lines
+557
to
+571
| const auto& pvm = mRecoCont.getPrimaryVertexMatchedTrackRefs(); | ||
| for (int i{0}; i < mPVs.size(); ++i) { | ||
| const auto& pv = mPVs[i]; | ||
| const auto& m = pvm[i]; | ||
| // count the number of ITS tracks that were associated to this PV | ||
| // then one can plot the number of tracks contributing to a PV against the available pool | ||
| // (+ ITS tracks only in OB which by constructing cannot contribute). | ||
| Double_t c{0.}; | ||
| for (int src = GIndex::NSources; src--;) { | ||
| if (!GIndex::includesDet(DetID::ITS, src)) { | ||
| continue; | ||
| } | ||
| c += m.getEntriesOfSource(src); | ||
| } | ||
| ((mIsHI) ? mPVNContVsITSTracksPbPb : mPVNContVsITSTracks)->Fill(pv.getNContributors(), c); |
Collaborator
Author
There was a problem hiding this comment.
Hi @shahor02, does the accounting look correct to you?
Collaborator
There was a problem hiding this comment.
Sorry, missed the question...
If the aim is to show the evolution of the pool size vs ncontrib, it is fine, but they will be strongly correlated.
The limits of histos look bit strange: the number of ITS time-associated tracks should be only a few 10% higher than the contributors, not an order of magnitude.
Collaborator
Author
There was a problem hiding this comment.
Thanks, actually I should have not pinged you, sorry about that. Since I will not be available for the next three weeks, I will close this and afterward continue working on this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.