Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Jan 29, 2025

  • Avoid using overloaded{} in templates
  • Fix index binding not happening due to typo (is_self_index_column used in place if is_index_column)

@aalkin aalkin requested a review from a team as a code owner January 29, 2025 13:21
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ktf
Copy link
Member

ktf commented Feb 3, 2025

@sy-c apparently kafka is now a requirement on cc8 for Readout. Can that be made optional and only enabled if Kafka itself is found (e.g. via LIBRDKAFKA_REVISION)?

@sy-c
Copy link
Collaborator

sy-c commented Feb 3, 2025

Hello @ktf, the kafka dependency is inherited from the monitoring library. Is there a problem with that ?

@alibuild
Copy link
Collaborator

alibuild commented Feb 3, 2025

Error while checking build/O2/fullCI_slc9 for 859ec3d at 2025-02-14 18:43:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile o2-raw-file-reader-workflow.log
o2-raw-file-reader-workflow.log:[40630:internal-dpl-ccdb-backend]: [18:42:59][ERROR] Exception while running: Fatal error. Rethrowing.
o2-raw-file-reader-workflow.log-[40630:internal-dpl-ccdb-backend]: [18:42:59][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-ft0-flp-dpl-workflow, device shutting down. Reason: Fatal error
[40630:internal-dpl-ccdb-backend]: [18:42:59][ERROR] Failed to open file alien:///alice/data/CCDB/FT0/Config/LookupTable/15/61584/31bd6402-c186-11ed-a9a7-200114580204?filetype=raw
[40630:internal-dpl-ccdb-backend]: [18:42:59][FATAL] Unable to find object FT0/Config/LookupTable/1550600800000
[40630:internal-dpl-ccdb-backend]: [18:42:59][ERROR] Exception while running: Fatal error. Rethrowing.
[40630:internal-dpl-ccdb-backend]: [18:42:59][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-ft0-flp-dpl-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 40630 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 40630 (exit 128)
[INFO]    - First error: [18:42:59][FATAL] Unable to find object FT0/Config/LookupTable/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (40630) had at least one message above severity 5: Unable to find object FT0/Config/LookupTable/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/e29d672985dd314ab4b75adf6b4392cc18880a4b/slc9_x86-64/o2checkcode/1.0-local411/etc/modulefiles
++ cat
--

Full log here.

@aalkin aalkin force-pushed the improve-concepts branch from 98b43a0 to 30654a8 Compare March 28, 2025 13:16
@aalkin
Copy link
Member Author

aalkin commented Mar 28, 2025

@ktf I have update the PR removing the bindings_pack_t and rebasing on top of the current dev. Could you please check again how it affects the binaries size?

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 30654a8 at 2025-03-28 19:14:

## sw/BUILD/O2-latest/log
CMake Error at cmake/O2RootMacroExclusionList.cmake:87 (message):

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Apr 8, 2025

Error while checking build/O2/fullCI_slc9 for 6c618f3 at 2025-05-14 05:23:

## sw/BUILD/arrow-latest/log
/sw/BUILD/fc134dcce0f158451af80df157aee53089fc91d8/arrow/src_tmp/cpp/src/gandiva/precompiled/arithmetic_ops.cc:18:10: fatal error: 'cmath' file not found
ninja: build stopped: subcommand failed.

Full log here.

@aalkin aalkin marked this pull request as draft May 17, 2025 06:01
@github-actions
Copy link
Contributor

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Jun 17, 2025
@github-actions github-actions bot closed this Jun 22, 2025
@aalkin aalkin deleted the improve-concepts branch December 11, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants