Skip to content

DPL Analysis: Remove selected pack rework #14284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aalkin wants to merge 21 commits into from
Closed

DPL Analysis: Remove selected pack rework #14284

aalkin wants to merge 21 commits into from
+120 −101

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented May 16, 2025

Alternative to #13915 that hopefully should not increase the size of the compiled binaries.

@ktf

aalkin and others added 17 commits May 16, 2025 12:19
@aalkin
remove obsolete concept
4152761
@aalkin
DPL Analysis: remove unnecessary instances of selected_pack
9a6f531
@aalkin
fixup! DPL Analysis: remove unnecessary instances of selected_pack
a2312ae
@aalkin
fixup! DPL Analysis: remove unnecessary instances of selected_pack
16ea3a8
@aalkin
fixup! DPL Analysis: remove unnecessary instances of selected_pack
9f7e13e
@aalkin
fixup! DPL Analysis: remove unnecessary instances of selected_pack
b472ec7
@aalkin
fixup! DPL Analysis: remove unnecessary instances of selected_pack
84cee9a
@aalkin
fixup! DPL Analysis: remove unnecessary instances of selected_pack
4d3fa45
@aalkin
use requirements instead of if-constexpr
c67d408
@aalkin
fixup! use requirements instead of if-constexpr
8234bde
@aalkin
avoid overloaded{}; fix index binding ignored in certain cases
f09930a
@aalkin
format
be7018a
@aalkin
get rid of bindings_pack_t
4e3732b
@aalkin
do not use all_columns pack where the template arguments are available
5f7c492
@alibuild @aalkin
Please consider the following formatting changes
9e77fe4
@aalkin
reduce amount of symbols
016e431
@aalkin
fixup! reduce amount of symbols
d52443d
@aalkin aalkin requested a review from a team as a code owner May 16, 2025 11:31
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request May 16, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented May 16, 2025

Error while checking build/O2/fullCI_slc9 for 0a1134f at 2025-05-16 14:17:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 16, 2025

Error while checking build/O2/fullCI_slc9 for 2507ed2 at 2025-05-16 17:24:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1216:44: error: template argument 4 is invalid
/sw/SOURCES/O2/14284-slc9_x86-64/0/Framework/Core/include/Framework/ASoA.h:1218:9: error: template argument 4 is invalid
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 19, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for 8dd344d at 2025-06-16 01:52:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:

Full log here.

@aalkin aalkin marked this pull request as draft June 18, 2025 11:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2025

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Jul 19, 2025
@github-actions github-actions bot closed this Jul 24, 2025
@aalkin aalkin deleted the remove-selected-pack-rework branch December 11, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aalkin @alibuild